1753463 - Bookmark trees stop expanding/collapsing folders after a PC Sleep

Status: RESOLVED DUPLICATE of bug 1839304

(Firefox :: Bookmarks & History, defect, P2)

Description

[Tom]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:96.0) Gecko/20100101 Firefox/96.0

Steps to reproduce:

leaving firefox open and PC goes to sleep, after waking pc, bookmarks folders in the bookmark menu sidebar no longer open or close - they are frozen. however, bookmarks visible in any of the open folders still function - the folder arrow marker no longer opens or closes the folder

Actual results:

after waking pc, bookmarks folders in the bookmark menu in the sidebar no longer open or close - the folders are frozen. however, bookmarks visible in the open folders still function.

Expected results:

clicking the arrow next to the bookmark folder should open or close the folder

Comment 1

[Tom]

closing firefox and re-opening fixes the problem and bookmark folders open/close as normal - restoring session continues to work ok, upon waking pc with firefox left open when it goes into sleep mode, then bookmark folders then become "frozen" again

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Peter Magyari (Desktop QA)]

Hi,

I wasn't able to reproduce the issue you've mentioned, all of the bookmarks function as expected on my end after waking the PC from sleep.

Could you check if this also occurs while using a new profile? (import or add a few bookmarks manually)
Here is a link that can help: https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles

Thank you!

Comment 4

[Tom]

Was not able to re-create the bug. Not sure what caused it now. Just woke pc from overnight sleep with Firefox still open and all is normal, no problems with bookmark folders. Kind of frustrated now.

It happened 2x last week after I left pc in sleep mode overnight and woke it next day to resume working on a site at Wordpress.com. I had several other tabs open, maybe 8 or so, at the time. I closed a few tabs since that time which I think is the only change and no longer have the site open at Wordpress. As far as I recall only other open programs were keepass and the win file explorer. The first occurrence I ignored it as a one off glitch. After second time, figured it might not be so rare. I have a good number of bookmarks organized in folders. It was pretty weird to try to open a folder and get no response, same happened when I tried to close an open folder.

Comment 5

[Tom]

(In reply to Peter_M from comment #3)

Hi,

I wasn't able to reproduce the issue you've mentioned, all of the bookmarks function as expected on my end after waking the PC from sleep.

Could you check if this also occurs while using a new profile? (import or add a few bookmarks manually)
Here is a link that can help: https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles

Thank you!

Was not able to re-create the bug. Not sure what caused it now. Just woke pc from overnight sleep with Firefox still open and all is normal, no problems with bookmark folders. Kind of frustrated now.

It happened 2x last week after I left pc in sleep mode overnight and woke it next day to resume working on a site at Wordpress.com. I had several other tabs open, maybe 8 or so, at the time. I closed a few tabs since that time which I think is the only change and no longer have the site open at Wordpress. As far as I recall only other open programs were keepass and the win file explorer. The first occurrence I ignored it as a one off glitch. After second time, figured it might not be so rare. I have a good number of bookmarks organized in folders. It was pretty weird to try to open a folder and get no response, same happened when I tried to close an open folder.

Comment 6

[zlice]

https://bugzilla.mozilla.org/show_bug.cgi?id=1755089

https://bugzilla.mozilla.org/show_bug.cgi?id=1753862

Possibly related. Didn't think of sleep til I read this but I've seen issues like this while running Firefox between sleeps.

Comment 9

[Mark Banner (:standard8)]

When this occurs, do any errors or messages appear on the browser console?

You can access the browser console from the application menu (three bars) -> More Tools -> Browser Console

Comment 10

[zlice]

Ill try to remember and take a look next time. Thanks

Comment 11

[Morey Behrens]

My bug report was closed and this does seem to be the same issue.
My PC does not go to sleep, so I don't think it has anything to do with sleep mode. I do shutdown every night.
My routine after PC startup is to open FF and this instance has 6 pinned tabs (Google apps Gmail, Drive, etc) and one regular tab - my Home Window - DuckDuckGo.
I have another FF instance with just Google Voice running in it. One tab.
Other FF instances will be opened for other browsing, the first 2 instances will stay on my desktop nearly all of the time.
I will see the issue after these instances have been running for most of the day. Though I have not seen it lately.
I did have one morning where the first FF instance I opened had the issue.
When one instance is experiencing the issue, others may not, and I can start a new instance it will typically be OK.
Sometimes the Bookmarks sidebar is not displaying any bookmarks.
I have 3 add-ons extensions: DuckDuckGo, UBlock Origin, and Facebook Container.
Theme: Dark
Plugins: Open H264... Cisco, Widevine content decryption...Google
I'll check the console the next time it happens and report back

Comment 12

[Morey Behrens]

Here is a console error when this occurs

Uncaught
Exception { name: "NS_ERROR_ILLEGAL_VALUE", message: "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavHistoryResult.removeObserver]", result: 2147942487, filename: "chrome://browser/content/places/treeView.js", lineNumber: 1633, columnNumber: 0, data: null, stack: "PTV_setTree@chrome://browser/content/places/treeView.js:1633:24\n", location: XPCWrappedNative_NoHelper }
​
columnNumber: 0
​
data: null
​
filename: "chrome://browser/content/places/treeView.js"
​
lineNumber: 1633
​
location: XPCWrappedNative_NoHelper { QueryInterface: QueryInterface(), filename: Getter, name: Getter, … }
​
message: "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavHistoryResult.removeObserver]"
​
name: "NS_ERROR_ILLEGAL_VALUE"
​
result: 2147942487
​
stack: "PTV_setTree@chrome://browser/content/places/treeView.js:1633:24\n"
​
<prototype>: ExceptionPrototype { toString: toString(), name: Getter, message: Getter, … }
treeView.js:1633

Comment 13

[Morey Behrens]

Attachment: Browser Console Error

My primary FF instance Bookmarks sidebar is now blank except for the section headers "Bookmarks Toolbar", "Bookmarks Menu", etc.
A new FF instance is OK. The browser I am writing this in is fine.
The top 4 Instances on the Win Taskbar are blank bookmarks. The 5th is populated but not working, will not expand-collapse.
The last 2 instances, started after the event began, are working correctly.

I did just receive a Google Voice call that I engaged by clicking the notification that popped up. During the call I discovered that the event was occurring. 

-----------------
This error just showed up on the console

Comment 14

[Morey Behrens]

My primary FF instance Bookmarks sidebar is now blank except for the section headers "Bookmarks Toolbar", "Bookmarks Menu", etc.
A new FF instance is OK. The browser I am writing this in is fine.
The top 4 Instances on the Win Taskbar are blank bookmarks. The 5th is populated but not working, will not expand-collapse.
The last 2 instances, started after the event began, are working correctly.

I did just receive a Google Voice call that I engaged by clicking the notification that popped up. During the call I discovered that the event was occurring.

Comment 15

[Morey Behrens]

I've done some testing and Google Voice calls engaged by notifications have not caused the issues with the Bookmarks sidebar

Comment 16

[Tom]

No luck trying to reproduce on my machine so far. Will check console in the event I can recreate it.

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 18

[Monica Chiorean]

I could not reproduce the issue on Win10, using build 98.0a1 (20220203003951) and steps from description and from comment#11.

Comment 19

[Marco Bonardo [:mak]]

(In reply to Morey Behrens from comment #12)

Uncaught
Exception { name: "NS_ERROR_ILLEGAL_VALUE", message: "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavHistoryResult.removeObserver]", result: 2147942487, filename: "chrome://browser/content/places/treeView.js", lineNumber: 1633, columnNumber: 0, data: null, stack: "PTV_setTree@chrome://browser/content/places/treeView.js:1633:24\n", location: XPCWrappedNative_NoHelper }

This is surely related to the problem, but it's hard to understand what is exactly causing it. The PC Sleep in the middle seems to suggest some object is not restored as expected, or GCed, and then the Treeview is working with zombie objects.

Comment 20

[Marco Bonardo [:mak]]

We should understand why weak observer cause removeObserver to throw... then we can eventually try/catch the call.

Comment 21

[EarlgreyTea]

The same issue is caused by another procedure and I will report it here.
After launching the app on the site BookLive, the bookmark trees will stop expanding / collapsing folders.

Steps to reproduce:

1. Download from https://booklive.jp/download#windows_link and install the BookLive app.
2. Start Firefox and open the bookmark tree in the sidebar.
3. Start BookLive app.
4. Click on the bookmark tree.
5. Quit Booklive app.

Actual results:

• Unable to expand bookmark tree in step 4.
• The following exception error is displayed on the browser console in step 5.

Uncaught
Exception { name: "NS_ERROR_ILLEGAL_VALUE", message: "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) 
[nsINavHistoryResult.removeObserver]", result: 2147942487, filename: "chrome://browser/content/places/treeView.js", lineNumber: 1633,
columnNumber: 0, data: null, stack: "PTV_setTree@chrome://browser/content/places/treeView.js:1633:24\n", location: 
XPCWrappedNative_NoHelper }

Expected results:
Bookmark tree can be expanded and no exception error occurs.

Additional Information:
This issue occurs in Firefox 94 and above.

Regression Window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=12d7a7278a958eeeb863e8d6d36ec030488aeba1&tochange=454a9b07d164c2824388c758ded0036a76c56287

Comment 22

[EarlgreyTea]

Attachment: treeView.js_line_1633.jpg

Comment 23

[EarlgreyTea]

(In reply to Marco Bonardo [:mak] from comment #20)

We should understand why weak observer cause removeObserver to throw... then we can eventually try/catch the call.

I have reported steps to ensure that the bug is reproduced. And there is also a regression window.
I don't know what the BookLive app is doing, but I hope this bug will be resolved by creating a bug situation.

Comment 24

[zlice]

https://bugzilla.mozilla.org/show_bug.cgi?id=1758561

May be related, seems to have solved my issues with weird UI behaviors and crashing.

Comment 25

[Tom]

Been some time and I have not been able to reproduce this issue. Looking at 1797799 brought to mind that, although I don’t recall installing any new fonts, I did open and use a variety of previously unused fonts in adobe illustrator when creating a logo image for the Wordpress site I was working on at the time. Just possibly I did download a new font but can’t recall for sure. In any event, I have not been able to reproduce the original issue.

Comment 27

[Marco Bonardo [:mak]]

I suspect bug 1839304 may have helped here, it would be nice to know if this keeps happening after upgrading to Firefox 122 (once available, or using current Nightly)

Comment 28

[EarlgreyTea]

(In reply to Marco Bonardo [:mak] from comment #27)

I suspect bug 1839304 may have helped here, it would be nice to know if this keeps happening after upgrading to Firefox 122 (once available, or using current Nightly)

I tried the steps I reported in comment #22.
In Firefox 120.0.1, when the BookLive app started, bookmarks could not be expanded / collapsed and the error was displayed in the browser console.
Both issues no longer occur in Firefox Nightly 122.0a1 (20231203092644).

Comment 29

[Marco Bonardo [:mak]]

Let's call it a dupe, until someone can still reproduce it after the fix.