1839417 - Move some code related to origin operations to separate source files

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

dom/quota/ActorsParent.cpp is already quite big and the code related to origin operations needs to be heavily adjusted for bug 1749504 and then bug 1671932. It would be good to move the code to separate source files, so it will be easier to find relevant code and track dependencies.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1839417 - Remove duplicated code for assertions; r=#dom-storage

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1839417 - Move RegisterNormalOriginOp/UnregisterNormalOriginOp to QuotaManager; r=#dom-storage

This is done in a separate patch before operations are actually moved outside
ActorsParent.cpp

Depends on D181476

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1839417 - Move QuotaManager::CollectPendingOriginsForListing implementation to QuotaManagerImpl.h; r=#dom-storage

QuotaManager::CollectPendingOriginsForListing is a public template function so
it shouldn't be implemented in a cpp file.
(needed for moving operations outside ActorsParent.cpp)

Depends on D181477

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1839417 - Move sanitization methods to separate files; r=#dom-storage

(needed for moving operations outside ActorsParent.cpp)

Depends on D181478

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1839417 - Move stream helpers to separate files; r=#dom-storage

(needed for moving operations outside ActorsParent.cpp)

Depends on D181479

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c05804783908
Remove duplicated code for assertions; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/c81f0e408508
Move RegisterNormalOriginOp/UnregisterNormalOriginOp to QuotaManager; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/193493b296e0
Move QuotaManager::CollectPendingOriginsForListing implementation to QuotaManagerImpl.h; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/6f275561722e
Move sanitization methods to separate files; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/e975cb149fac
Move stream helpers to separate files; r=dom-storage-reviewers,asuth

Comment 7

[Cristina Horotan [:chorotan]]

Backed out 5 changesets (bug 1839417) for causing build bustage at ActorsParent.cpp

Backout: https://hg.mozilla.org/integration/autoland/rev/4c90403735bebf09d72af91e99745cfcbbae2a35

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=e975cb149fac5a27eb937d5318623f85fc3279ba&selectedTaskRun=NUK6vv25Spe5gNSGce9xkg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=420105304&repo=autoland&lineNumber=15190

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24f10ad45ba3
Remove duplicated code for assertions; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/90815a533676
Move RegisterNormalOriginOp/UnregisterNormalOriginOp to QuotaManager; r=dom-storage-reviewers,asuth

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/24f10ad45ba3
https://hg.mozilla.org/mozilla-central/rev/90815a533676

Comment 10

[Jan Varga [:janv]]

The issue with base tool chains has been fixed and some patches relanded.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e8c4a208399
Move QuotaManager::CollectPendingOriginsForListing implementation to QuotaManagerImpl.h; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/46f540d28d15
Move sanitization methods to separate files; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/4f7deb118e0b
Move stream helpers to separate files; r=dom-storage-reviewers,asuth

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3e8c4a208399
https://hg.mozilla.org/mozilla-central/rev/46f540d28d15
https://hg.mozilla.org/mozilla-central/rev/4f7deb118e0b