1840545 - Move all code related to origin operations to separate source files

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

This is a continuation of bug 1839417.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1840545 - Move CreateDirectoryMetadata and CreateDirectoryMetadata2 to QuotaManager class; r=#dom-storage

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1840545 - Move some constants to Constants.h; r=#dom-storage

These constants will be used in other source files.

Depends on D182172

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1840545 - Move some file utils to separate files; r=#dom-storage

Depends on D182173

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1840545 - Move OriginOperationBase to separate files; r=#dom-storage

Depends on D182174

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1840545 - Move NormalOriginOperationBase to separate files; r=#dom-storage

Depends on D182175

Comment 6

[Jan Varga [:janv]]

Attachment: Bug 1840545 - Change QuotaUsageRequestBase::Init to be a pure virtual method; r=#dom-storage

This makes it clear which derived classes need storage initialization.

Depends on D182176

Comment 7

[Jan Varga [:janv]]

Attachment: Bug 1840545 - Remove QuotaUsageRequestBase::Init; r=#dom-storage

Storage is now initialized explicitly in each DoDirectoryWork method which
requires it.

Depends on D182177

Comment 8

[Jan Varga [:janv]]

Attachment: Bug 1840545 - Change QuotaRequestBase::Init to be a pure virtual method; r=#dom-storage

This makes it clear which derived classes need storage initialization.

Depends on D182178

Comment 9

[Jan Varga [:janv]]

Attachment: Bug 1840545 - Implement QuotaRequestBase::Init only in final classes; r=#dom-storage

This makes it clear which final classes need storage initialization.

Depends on D182179

Comment 10

[Jan Varga [:janv]]

Attachment: Bug 1840545 - Remove QuotaRequestBase::Init; r=#dom-storage

Storage is now initialized explicitly in each DoDirectoryWork method which
requires it.

Depends on D182180

Comment 11

[Jan Varga [:janv]]

Attachment: Bug 1840545 - Fix FinalizeOriginEvictionOp to follow standard state advancing; r=#dom-storage

FinalizeOriginEvictionOp was avoiding to process some initial states and
was starting directly on the IO thread or directly dispathing to the IO thread.
The operations now operates in a standard way, so it starts immediatelly on the
PBackground thread or is dispatched to the PBackground thread. The extra
dispatch to the PBackground thread has only negligible performance impact.
The code and the processing is now much cleaner.

Depends on D182181

Comment 12

[Jan Varga [:janv]]

Attachment: Bug 1840545 - Create a base class for resolvable normal origin operations; r=#dom-storage

Depends on D182182

Comment 13

[Jan Varga [:janv]]

Attachment: Bug 1840545 - Move QuotaUsageRequestBase to separate files; r=#dom-storage

Depends on D182183

Comment 14

[Jan Varga [:janv]]

Attachment: Bug 1840545 - Move QuotaRequestBase to separate files; r=#dom-storage

Depends on D182184

Comment 15

[Jan Varga [:janv]]

Attachment: Bug 1840545 - Move all origin operations to separate files; r=#dom-storage

Depends on D182185

Comment 16

[Jan Varga [:janv]]

Attachment: Bug 1840545 - Rename ResolvableOriginOp to ResolvableNormalOriginOp; r=#dom-storage

Depends on D182186

Comment 17

[Jan Varga [:janv]]

https://treeherder.mozilla.org/jobs?repo=try&revision=18662f2513328106cb7291a5412fb23762196f61

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f910ed7c78ca
Move CreateDirectoryMetadata and CreateDirectoryMetadata2 to QuotaManager class; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/4e302ea298e9
Move some constants to Constants.h; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/63fa1dd5d595
Move some file utils to separate files; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/3eaf87766920
Move OriginOperationBase to separate files; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/ed80d40e7d63
Move NormalOriginOperationBase to separate files; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/9c097acf4991
Change QuotaUsageRequestBase::Init to be a pure virtual method; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/71a5a6dc926b
Remove QuotaUsageRequestBase::Init; r=dom-storage-reviewers,jari

Comment 19

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f910ed7c78ca
https://hg.mozilla.org/mozilla-central/rev/4e302ea298e9
https://hg.mozilla.org/mozilla-central/rev/63fa1dd5d595
https://hg.mozilla.org/mozilla-central/rev/3eaf87766920
https://hg.mozilla.org/mozilla-central/rev/ed80d40e7d63
https://hg.mozilla.org/mozilla-central/rev/9c097acf4991
https://hg.mozilla.org/mozilla-central/rev/71a5a6dc926b

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86e1231b7a83
Change QuotaRequestBase::Init to be a pure virtual method; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/1ba8085e6867
Implement QuotaRequestBase::Init only in final classes; r=dom-storage-reviewers,jari

Comment 21

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/86e1231b7a83
https://hg.mozilla.org/mozilla-central/rev/1ba8085e6867

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2666a14e0b07
Remove QuotaRequestBase::Init; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/ef1ee95f3286
Fix FinalizeOriginEvictionOp to follow standard state advancing; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/d3648c29ef18
Create a base class for resolvable normal origin operations; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/198e7e054351
Move QuotaUsageRequestBase to separate files; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/6ab059d1b30d
Move QuotaRequestBase to separate files; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/e17b2a44afe7
Move all origin operations to separate files; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/2d6f9e9eae27
Rename ResolvableOriginOp to ResolvableNormalOriginOp; r=dom-storage-reviewers,jari

Comment 23

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2666a14e0b07
https://hg.mozilla.org/mozilla-central/rev/ef1ee95f3286
https://hg.mozilla.org/mozilla-central/rev/d3648c29ef18
https://hg.mozilla.org/mozilla-central/rev/198e7e054351
https://hg.mozilla.org/mozilla-central/rev/6ab059d1b30d
https://hg.mozilla.org/mozilla-central/rev/e17b2a44afe7
https://hg.mozilla.org/mozilla-central/rev/2d6f9e9eae27