1839439 - PiP progress bar appears too high for wide videos (21:9) at some window sizes

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Kestrel]

Attachment: Control overlay appears too high for wide aspect ratio videos

STR:

1. Visit a youtube video with a wide 21:9 aspect ratio (eg https://youtube.com/watch?v=Ttl8Gg-P-Ao).
2. Open the video in PiP window.
3. Resize the PiP window large enough that the volume slider first starts to appear.

Control overlay including progress bar appears too high in frame except for volume slider and timestamp.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e0262ee6a9a7a642c11266a1e9cfa4bc3fbd4b3b&tochange=8740be66493fa62886c4df2a8895068ed554ef44

Regressed by Bug 1580095.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:niklas, since you are the author of the regressor, bug 1580095, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1839439 - Hide audio scrubber on wide apsect ratio videos. r=#pip-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/940739d0aaac
Hide audio scrubber on wide apsect ratio videos. r=pip-reviewers,mhowell

Comment 5

[Cristina Horotan [:chorotan]]

Backed out changeset 940739d0aaac (bug 1839439) for causing bc failures ast browser_audioScrubber.js

Backout: https://hg.mozilla.org/integration/autoland/rev/38086418279c11860cdd0b8cf7ac8b717bb78d3e

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Wx97cBKHQdGacjXzT3t_5Q.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=940739d0aaacc0023555979e3003aeb5eccd9725

Failure log: https://treeherder.mozilla.org/logviewer?job_id=420157837&repo=autoland&lineNumber=12297

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ba9b54b1c29
Hide audio scrubber on wide apsect ratio videos. r=pip-reviewers,mhowell,kpatenio

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3ba9b54b1c29

Comment 8

[Peter Magyari (Desktop QA)]

I have verified the fix with multiple videos from HBO Max, PrimeVideo and Youtube using Firefox Nightly 116.0a1 (20230625195949) on Windows 7/10, Ubuntu 20.04 and MacOS 11.6.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1580095