Closed Bug 1580095 Opened 5 years ago Closed 1 year ago

Add volume control scrollbar to PiP mini-player

Categories

(Toolkit :: Picture-in-Picture, enhancement)

Desktop
All
enhancement

Tracking

()

RESOLVED FIXED
116 Branch
Tracking Status
relnote-firefox --- 116+
firefox116 --- fixed

People

(Reporter: lolipopplus, Assigned: niklas)

References

(Depends on 1 open bug, Regressed 1 open bug, )

Details

(Whiteboard: pm-triaged)

Attachments

(5 files)

Currently we have restore, paused/continue and close button. Is there any reason why we don't have a volume control scrollbar?

Status: UNCONFIRMED → NEW
Component: Audio/Video: Playback → Video/Audio Controls
Ever confirmed: true
Product: Core → Toolkit
Blocks: videopip
No longer blocks: 1463402
Component: Video/Audio Controls → Picture-in-Picture

I'm interested in adding the functionality for a volume slider, I've added an image of what the proposed change might look like.

Hi Max,

My apologies for the late reply! We're going to work on the additional playback controls in PiP a little later in the year with the design team, so unfortunately this ticket isn't ready for engineering yet.

https://bugzilla.mozilla.org/show_bug.cgi?id=1742457 - we have an Outreachy meta bug with some work that might be of interest to you.
Please let me know if any of the enhancements or defects there look interesting to you.

Severity: normal → S3

The new improved video controls for Picture-in-Picture have been enabled in Nightly, but still no sign of the volume slider :)

Hi,
Volume can be adjusted via arrows up/down keys and, unfortunately, there are no immediate plans to work on the volume slider for Picture-in-Picture.

No longer blocks: videopip
Whiteboard: pm-triaged

Why is this not a planned feature?
I think it's a big accessibility issue, what if a user don't have access to a keyboard?

Also people expect any video player to have a volume slider, that's just industry standard.

Firefox is a large product with many high-priority needs (including accessibility) and a limited number of engineers who can attend to these needs. All work is ranked against each other, and priorities are decided not within one component, but within the whole product. There are two ways users can impact these decisions:

  • You are welcome to submit a patch to support the volume slider in PiP in this ticket. It is kept open for this reason.
  • You can join discussions and feature requests on Mozilla Connect. Top ideas get ranked, prioritized, and implemented when feasible.
Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED

Release Note Request (optional, but appreciated):
[Why is this notable]:
[Affects Firefox for Android]: No
[Suggested wording]: You asked, and we listened! The volume slider is now available in Picture-in-Picture.
[Links (documentation, blog post, etc)]:

relnote-firefox: --- → ?
Target Milestone: --- → 116 Branch
Attachment #9336766 - Attachment description: Bug 1580095 - Add audio scrubber to PiP. r=#pip-reviewers → WIP: Bug 1580095 - Add audio scrubber to PiP. r=#pip-reviewers
Attachment #9336766 - Attachment description: WIP: Bug 1580095 - Add audio scrubber to PiP. r=#pip-reviewers → Bug 1580095 - Add audio scrubber to PiP. r=#pip-reviewers
Attachment #9338951 - Attachment description: WIP: Bug 1580095 - Update youtube wrapper. r=#pip-reviewers → Bug 1580095 - Update youtube wrapper. r=#pip-reviewers
Attachment #9338952 - Attachment description: WIP: Bug 1580095 - Update netflix wrapper. r=#pip-reviewers → Bug 1580095 - Update netflix wrapper. r=#pip-reviewers
Attached image PIP 01 with CC.png

The slider is always visible when the width of the PiP window is greater than 630px.

Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/66a695629d4b
Add audio scrubber to PiP. r=pip-reviewers,desktop-theme-reviewers,kpatenio,dao
https://hg.mozilla.org/integration/autoland/rev/2d042439b759
Update youtube wrapper. r=pip-reviewers,mhowell
https://hg.mozilla.org/integration/autoland/rev/fa8f9b71e4db
Update netflix wrapper. r=pip-reviewers,mhowell

Backed out for causing mochitests failures in browser_audioScrubber.js.

Flags: needinfo?(nbaumgardner)
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9372bbd6eb40
Add audio scrubber to PiP. r=pip-reviewers,desktop-theme-reviewers,kpatenio,dao
https://hg.mozilla.org/integration/autoland/rev/22765b6eea1b
Update youtube wrapper. r=pip-reviewers,mhowell
https://hg.mozilla.org/integration/autoland/rev/047ac9aaa0f7
Update netflix wrapper. r=pip-reviewers,mhowell
Regressions: 1838980

Backed out for causing bc failures on browser_mock_wrapper.js

Backout link

Push with failures

Failure log

Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c283d36bd275
Add audio scrubber to PiP. r=pip-reviewers,desktop-theme-reviewers,kpatenio,dao
https://hg.mozilla.org/integration/autoland/rev/69f603beeade
Update youtube wrapper. r=pip-reviewers,mhowell
https://hg.mozilla.org/integration/autoland/rev/8740be66493f
Update netflix wrapper. r=pip-reviewers,mhowell
Regressions: 1839439
Flags: needinfo?(nbaumgardner)
Blocks: 1843575
Regressions: 1819553
Depends on: 1874408
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: