1580095 - Add volume control scrollbar to PiP mini-player

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, enhancement)

Description

[lolipopplus]

Currently we have restore, paused/continue and close button. Is there any reason why we don't have a volume control scrollbar?

Comment 1

[Max]

Attachment: Proposed addition to PiP

I'm interested in adding the functionality for a volume slider, I've added an image of what the proposed change might look like.

Comment 2

[Ania]

Hi Max,

My apologies for the late reply! We're going to work on the additional playback controls in PiP a little later in the year with the design team, so unfortunately this ticket isn't ready for engineering yet.

https://bugzilla.mozilla.org/show_bug.cgi?id=1742457 - we have an Outreachy meta bug with some work that might be of interest to you.
Please let me know if any of the enhancements or defects there look interesting to you.

Comment 3

[Araxeus]

The new improved video controls for Picture-in-Picture have been enabled in Nightly, but still no sign of the volume slider :)

Comment 4

[Ania]

Hi,
Volume can be adjusted via arrows up/down keys and, unfortunately, there are no immediate plans to work on the volume slider for Picture-in-Picture.

Comment 5

[Araxeus]

Why is this not a planned feature?
I think it's a big accessibility issue, what if a user don't have access to a keyboard?

Also people expect any video player to have a volume slider, that's just industry standard.

Comment 6

[Ania]

Firefox is a large product with many high-priority needs (including accessibility) and a limited number of engineers who can attend to these needs. All work is ranked against each other, and priorities are decided not within one component, but within the whole product. There are two ways users can impact these decisions:

• You are welcome to submit a patch to support the volume slider in PiP in this ticket. It is kept open for this reason.
• You can join discussions and feature requests on Mozilla Connect. Top ideas get ranked, prioritized, and implemented when feasible.

Comment 7

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1580095 - Add audio scrubber to PiP. r=#pip-reviewers

Comment 8

[Jon S]

Related Connect thread for this request: https://connect.mozilla.org/t5/ideas/picture-in-picture-mode-an-option-to-control-volume-increase-or/idi-p/19323

Comment 9

[Ania]

Release Note Request (optional, but appreciated):
[Why is this notable]:
[Affects Firefox for Android]: No
[Suggested wording]: You asked, and we listened! The volume slider is now available in Picture-in-Picture.
[Links (documentation, blog post, etc)]:

Comment 10

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1580095 - Update youtube wrapper. r=#pip-reviewers

Depends on D179556

Comment 11

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1580095 - Update netflix wrapper. r=#pip-reviewers

Depends on D180873

Comment 12

[Ania]

Attachment: PIP 01 with CC.png

The slider is always visible when the width of the PiP window is greater than 630px.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66a695629d4b
Add audio scrubber to PiP. r=pip-reviewers,desktop-theme-reviewers,kpatenio,dao
https://hg.mozilla.org/integration/autoland/rev/2d042439b759
Update youtube wrapper. r=pip-reviewers,mhowell
https://hg.mozilla.org/integration/autoland/rev/fa8f9b71e4db
Update netflix wrapper. r=pip-reviewers,mhowell

Comment 14

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_audioScrubber.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_audioScrubber.js | Found a tab after previous test timed out: http://example.com/browser/toolkit/components/pictureinpicture/tests/test-page.html -

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9372bbd6eb40
Add audio scrubber to PiP. r=pip-reviewers,desktop-theme-reviewers,kpatenio,dao
https://hg.mozilla.org/integration/autoland/rev/22765b6eea1b
Update youtube wrapper. r=pip-reviewers,mhowell
https://hg.mozilla.org/integration/autoland/rev/047ac9aaa0f7
Update netflix wrapper. r=pip-reviewers,mhowell

Comment 16

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_mock_wrapper.js

Backout link

Push with failures

Failure log

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c283d36bd275
Add audio scrubber to PiP. r=pip-reviewers,desktop-theme-reviewers,kpatenio,dao
https://hg.mozilla.org/integration/autoland/rev/69f603beeade
Update youtube wrapper. r=pip-reviewers,mhowell
https://hg.mozilla.org/integration/autoland/rev/8740be66493f
Update netflix wrapper. r=pip-reviewers,mhowell

Comment 18

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c283d36bd275
https://hg.mozilla.org/mozilla-central/rev/69f603beeade
https://hg.mozilla.org/mozilla-central/rev/8740be66493f

Comment 19

[Dianna Smith [:diannaS]]

Included in the Fx116 beta release notes https://www.mozilla.org/en-US/firefox/116.0beta/releasenotes/