1839493 - [wmfme] mfpmp process doesn't get clear properly

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Alastor Wu [:alwu]]

When testing media engine DRM playback, mfpmp process is used for SWDRM, which should be clear when the DRM playback is terminated. However, I found we didn't clean them properly, so there would be many mfpmp processes left even if we already close those tabs playing DRM video.

Comment 1

[Alastor Wu [:alwu]]

Attachment: WIP: Bug 1839493 - part1 : move event log into MFMediaEngineParen otherwise the profiler can't capture logs on the mfthread pool.

This helps debugging.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1839493 - part1 : add more logs.

Depends on D182829

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1839493 - part2 : properly clean up all media foundation related classes.

Depends on D182830

Comment 4

[Alastor Wu [:alwu]]

We're still waiting for the response from MS, but I'd like to land the current patches first, which solves some leaking cases. Landing them first would also allow us to be able to add EME API test for the PlayReady. I will file another bug to handle mfpmp process leak when playing the EME playback through the media engine.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1839493 - part3 : update threading assertion.

Depends on D182831

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1839493 - part4 : print log first before error return.

Depends on D183219

Comment 7

[Alastor Wu [:alwu]]

Filed bug 1842706 to track the leak issue for EME playback.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce5e6d72db16
part1 : add more logs. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/f02a82cb3633
part2 : properly clean up all media foundation related classes. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/242b0e8eda66
part3 : update threading assertion. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/7b1aceb985b3
part4 : print log first before error return. r=media-playback-reviewers,padenot

Comment 9

[Norisz Fay [:noriszfay]]

Backed out for causing bustages on MFMediaEngineParent.cpp

Backout link

Push with failures

Failure log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd6afbde650b
part1 : add more logs. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/4a8ee5d08e34
part2 : properly clean up all media foundation related classes. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/60df800dbdb0
part3 : update threading assertion. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/3a5e789acb24
part4 : print log first before error return. r=media-playback-reviewers,padenot

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/dd6afbde650b
https://hg.mozilla.org/mozilla-central/rev/4a8ee5d08e34
https://hg.mozilla.org/mozilla-central/rev/60df800dbdb0
https://hg.mozilla.org/mozilla-central/rev/3a5e789acb24