1839578 - ktlintFormat fails throwing ExceptionInInitializerError

Status: RESOLVED FIXED

(Firefox for Android :: General, defect, P1)

Description

[Mike a [:mavduevskiy]]

Steps to reproduce

1. checkout main branch. change any file
2. run ktlintFormat script

Expected behavior

ktlintFormat successfully finishes work

Actual behavior

Exception in thread "main" java.util.concurrent.ExecutionException: java.lang.ExceptionInInitializerError

Device information

• Firefox version:
• Android device model:
• Android OS version:

Any additional information?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1831352

:mcarare, since you are the author of the regressor, bug 1831352, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Mihai Adrian Carare [:mcarare]]

In JDK 17, it's not possible anymore to make a field accessible using reflection. The actual error here is:

Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field private transient java.lang.Object java.lang.Throwable.backtrace accessible: module java.base does not "opens java.lang" to unnamed module

A JVM argument for the ktlintFormat task can be added in order to allow reflection, making the fields in java.lang. classes accessible.

Note that it does not happen for Focus.

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1839578 - Allow ktlintFormat task to modify access java.lang class fields. (#2559)

Comment 4

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/e02b2023d0dd890b6d5a4eac0a485bea1e29e1d8
[main] Bug 1839578 - Allow ktlintFormat task to modify access java.lang class fields.

Comment 5

[Arturo Mejia [:amejia]]

Mihai Thanks for putting the patch, you made my day 🙌!

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1839578 - Allow ktlintFormat task to modify access java.lang class fields. (#2565)

Comment 7

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/7adaa3d006f3e5dafedafc00f7f3601f2f49fd99
[main] Bug 1839578 - Allow ktlintFormat task to modify access java.lang class fields.

Comment 8

[Mihai Adrian Carare [:mcarare]]

Already confirmed with people having this issue that it is solved now.
No additional QA is needed.