1839827 - Wrong error is displayed after importing Passwords from an empty or invalid CSV file

Status: VERIFIED FIXED

(Firefox :: Migration, defect, P1)

Description

[Giorgia Nichita, Release Desktop QA]

Attachment: Wrong error.png

Found in

• Nightly 116.0a1

Affected versions

• 116.0a1

Tested platforms

Affected platforms:

• Ubuntu 22
• Windows 10
• macOS 12

Preconditions

• ensure signon.management.page.fileImport.enabled is set on True in about:config.
• empty or invalid .csv file

Steps to reproduce

1. Open Firefox and choose to import Passwords from CSV file.
2. Select the file from the preconditions.
3. Observe the error displayed.

Expected result
"The file doesn't include any valid password data. Pick another file" error is displayed, according to the Figma spec.

Actual result
"FILE_FORMAT_ERROR" is displayed.

Regression range

• Not a regression. Started with implementation of CSV in new migration wizard.

Notes

• Screenshot attached.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:gmoldovan, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1839827 - Display a generic error message for password and bookmark file migrations despite the exception. r?kpatenio!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c736e40dd209
Display a generic error message for password and bookmark file migrations despite the exception. r=kpatenio,fluent-reviewers,flod

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c736e40dd209

Comment 6

[Giorgia Nichita, Release Desktop QA]

Verified as fixed on the latest Nightly build (20230623092529) using Windows 10, Ubuntu 22 and macOS 12. The correct error is displayed after importing Passwords from an empty or invalid CSV file.