1839944 - Rename mBaselineFromLastReflow in nsFlexContainerFrame

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Per dholbert's review comment in https://phabricator.services.mozilla.com/D181604#inline-1007067,

... we should probably rename this first variable to mFirstBaselineFromLastReflow for symmetry/clarity.

Agree. In addition, I feel maybe we could drop FromLastReflow for both variable for brevity, and add a comment saying that both are computed and cached in the last reflow.

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to Ting-Yu Lin [:TYLin] (UTC-8) from comment #0)

I feel maybe we could drop FromLastReflow for both variable for brevity, and add a comment saying that both are computed and cached in the last reflow.

That sounds fine to me, yeah. Thanks!

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1839944 - Rename two cached baseline variables in nsFlexContainerFrame. r?dholbert

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1680bc957eca
Rename two cached baseline variables in nsFlexContainerFrame. r=dholbert

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/1680bc957eca