1792750 - [css-flexbox-1] Flex container baselines with reverse direction.

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, defect)

Description

[Mozilla Apprentice]

A resolution was made for csswg-drafts/#7776.

[css-flexbox-1] Flex container baselines with reverse direction.

• RESOLVED: flex baselines take flex ordering into account so first/last use roughly *physical* directions

Discussion.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1792750 Part 1 - Remove an obsolete comment for FlexLine::LastBaselineOffset(). r?dholbert

We've removed the ability to reverse flex container's axes internally in
bug 1639053.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1792750 Part 2 - Pass FlexLayoutResult into PopulateReflowOutput(). r?dholbert

Depends on D181602

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1792750 Part 3 - Fix flex container baselines with reverse axes. r?dholbert

This is the spec describing flex container baselines.
https://drafts.csswg.org/css-flexbox-1/#flex-baselines

• Separate the cache for last baseline in FlexItem. This is needed beacuse we set
  an item's first baseline via SetAscent() after reflowing it. Any query to last
  baseline via ResolvedAscent(false) will wrongly return the first baseline.

• We used to compute flex container baseline from the first item in
  ReflowChildren(). Now we consolidate all the logic computing flex container
  baseline in PopulateReflowOutput().

Depends on D181603

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89934b1a4eda
Part 1 - Remove an obsolete comment for FlexLine::LastBaselineOffset(). r=dholbert
https://hg.mozilla.org/integration/autoland/rev/347fcb9e0578
Part 2 - Pass FlexLayoutResult into PopulateReflowOutput(). r=dholbert
https://hg.mozilla.org/integration/autoland/rev/895103478cfa
Part 3 - Fix flex container baselines with reverse axes. r=dholbert

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/89934b1a4eda
https://hg.mozilla.org/mozilla-central/rev/347fcb9e0578
https://hg.mozilla.org/mozilla-central/rev/895103478cfa