1840086 - Add-ons manager broken in Thunderbird

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Martin Giger [:freaktechnik]]

Attachment: screenshot.png

The add-ons manager in Thunderbird (and any other potential consumer of toolkit that doesn't bundle browser/) is broken by the loading of a browser/ ftl from bug 1838041.

Commenting out the load of that ftl fixes the add-on manager (while leaving the one string provided by that file untranslated).

Example logs from opening about:addons in Thunderbird:

Missing resource in locale en-US: browser/components/mozFiveStar.ftl
[fluent] Couldn't find a message: text-action-search-text-box-clear 2 addons
[dom/l10n] Errors during l10n mutation frame. 2 addons
Missing resource in locale en-US: browser/components/mozFiveStar.ftl
[fluent] Couldn't find a message: extension-enabled-heading 2 addons
[fluent] Couldn't find a message: addon-badge-recommended2 2 addons
[fluent] Couldn't find a message: addon-badge-line3 2 addons
[fluent] Couldn't find a message: addon-badge-verified2 2 addons
[fluent] Couldn't find a message: addon-badge-private-browsing-allowed2 2 addons
[fluent] Couldn't find a message: extension-enable-addon-button-label 2 addons
[fluent] Couldn't find a message: add-on-options-button 2 addons
[fluent] Couldn't find a message: addon-options-button 2 addons
[fluent] Couldn't find a message: install-postponed-message 2 addons
[fluent] Couldn't find a message: install-postponed-button 2 addons
[fluent] Couldn't find a message: remove-addon-button 2 addons
[fluent] Couldn't find a message: install-update-button 2 addons
[fluent] Couldn't find a message: preferences-addon-button 2 addons
[fluent] Couldn't find a message: report-addon-button addons
[fluent] Couldn't find a message: manage-addon-button addons
[fluent] Couldn't find a message: report-addon-button addons
[fluent] Couldn't find a message: manage-addon-button addons
[fluent] Couldn't find a message: list-empty-get-extensions-message 2 addons
Uncaught (in promise) undefined 2
[fluent] Couldn't find a message: atn-addons-heading-search-input 2 addons
[fluent] Couldn't find a message: extension-heading 2 addons
[dom/l10n] Errors during l10n mutation frame. 2 addons

The easiest fix would probably be to move mozFiveStar.ftl to be part of toolkit.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1838041

:niklas, since you are the author of the regressor, bug 1838041, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Elizabeth Mitchell]

Assigning myself to create a temporary fix so that Thunderbird does not have so many failures.

Yes, if the author of bug 1838041 could take this on or give guidance about how we could fix this, that would help a lot. Thank you.

Comment 3

[Elizabeth Mitchell]

I was not able to figure this out on my own. Unassigning.

Comment 4

[Rob Wu [:robwu]]

The ftl file should be migrated to toolkit, I suppose to https://searchfox.org/mozilla-central/source/toolkit/locales/en-US/toolkit

Add r=#fluent-reviewers to the review.

Comment 5

[Intermittent Failures Robot]

65 failures in 606 pushes (0.107 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 65

Platform and build breakdown:

• linux1804-64-qr: 6
  • opt: 3
  • debug: 3
• windows11-32-2009-qr: 8
  • debug: 4
  • opt: 4
• macosx1015-64-qr: 8
  • opt: 5
  • debug: 3
• windows11-64-2009-qr: 16
  • debug: 6
  • opt: 10
• linux1804-64-shippable-qr: 4
  • opt: 4
• windows11-64-2009-shippable-qr: 9
  • opt: 9
• windows11-32-2009-shippable-qr: 5
  • opt: 5
• linux1804-64-ccov-qr: 4
  • opt: 4
• macosx1015-64-shippable-qr: 5
  • opt: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1840086&startday=2023-06-23&endday=2023-06-23&tree=all

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Bug 1840086 - Port bug 1838041: Add moz-five-star reuseable component. r=#thunderbird-reviewers

Comment 7

[Rob Wu [:robwu]]

This should not be "fixed" by introducing a Thunderbird-specific file, but by moving the ftl from browser/ to toolkit/ as mentioned in comment 4.

Comment 8

[Richard Marti (:Paenglab)]

Yes, I know. Because I haven't seen any activity to move it I created this patch. When the move happens we can this patch back out again.

Comment 9

[Elizabeth Mitchell]

(In reply to Richard Marti (:Paenglab) from comment #8)

Yes, I know. Because I haven't seen any activity to move it I created this patch. When the move happens we can this patch back out again.

Thank you, Richard.

Yes, this will get fixed inside m-c/mozilla-central.

It will help to have a good option until that happens. Thank you. I will look the patch over.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1669c2903caa
Port bug 1838041: Add moz-five-star reuseable component. r=elizabeth

Comment 11

[Elizabeth Mitchell]

Richard's patch is a temporary fix until m-c is updated. This patch does resolve the many failing tests in c-c caused by changes in bug 1838041.

Comment 12

[Intermittent Failures Robot]

58 failures in 84 pushes (0.69 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 58

Platform and build breakdown:

• windows11-64-2009-qr: 15
  • debug: 6
  • opt: 9
• linux1804-64-qr: 5
  • debug: 2
  • opt: 3
• macosx1015-64-qr: 8
  • opt: 4
  • debug: 4
• windows11-32-2009-shippable-qr: 5
  • opt: 5
• windows11-32-2009-qr: 6
  • debug: 3
  • opt: 3
• linux1804-64-shippable-qr: 3
  • opt: 3
• windows11-64-2009-shippable-qr: 8
  • opt: 8
• linux1804-64-ccov-qr: 3
  • opt: 3
• macosx1015-64-shippable-qr: 5
  • opt: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1840086&startday=2023-06-24&endday=2023-06-24&tree=all

Comment 13

[Intermittent Failures Robot]

123 failures in 3880 pushes (0.032 failures/push) were associated with this bug in the last 7 days.

This is the #5 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 123

Platform and build breakdown:

• linux1804-64-qr: 11
  • opt: 6
  • debug: 5
• windows11-32-2009-qr: 14
  • debug: 7
  • opt: 7
• macosx1015-64-qr: 16
  • opt: 9
  • debug: 7
• windows11-64-2009-qr: 31
  • debug: 12
  • opt: 19
• linux1804-64-shippable-qr: 7
  • opt: 7
• windows11-64-2009-shippable-qr: 17
  • opt: 17
• windows11-32-2009-shippable-qr: 10
  • opt: 10
• linux1804-64-ccov-qr: 7
  • opt: 7
• macosx1015-64-shippable-qr: 10
  • opt: 10

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1840086&startday=2023-06-19&endday=2023-06-25&tree=all

Comment 14

[Dão Gottwald [:dao]]

(In reply to Elizabeth Mitchell from comment #11)

Richard's patch is a temporary fix until m-c is updated. This patch does resolve the many failing tests in c-c caused by changes in bug 1838041.

What bug covers fixing m-c if not this one (which is now assigned to Richard)?

Comment 15

[Rob Wu [:robwu]]

I'm going to close this bug and file a follow-up bug so that it is obvious what issue is being tracked.

• This bug: unblocking Thunderbird.
• bug 1840410: fix the m-c issue (and revert the work-around from this patch).

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1838041