1840410 - toolkit/content/widgets/moz-five-star/moz-five-star.mjs references browser/components/mozFiveStar.ftl

Status: RESOLVED FIXED

(Firefox :: Shopping, defect)

Description

[Rob Wu [:robwu]]

Reusable modules in toolkit should not reference Fluent files in browser/.

But moz-five-star.mjs loads browser/components/mozFiveStar.ftl at https://searchfox.org/mozilla-central/rev/d31e56f7b3c2c18b8071a7b2a2fb6b4e01e3d3e8/toolkit/content/widgets/moz-five-star/moz-five-star.mjs#8.

Consequently, Thunderbird broke (bug 1840086). As a work-around the file was copied to Thunderbird, but we should fix the issue by moving the ftl file to toolkit, I suppose to https://searchfox.org/mozilla-central/source/toolkit/locales/en-US/toolkit. Make sure to add r=#fluent-reviewers to the patch, to verify whether there migration if any is correct.

Once this bug is fixed, the work-around from bug 1840086 can be reverted.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1838041

:niklas, since you are the author of the regressor, bug 1838041, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1840410 - Move mozFiveStar.ftl to toolkit. r=#fluent-reviewers!

Comment 3

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1840410 - Remove temporary mozFiveStar.ftl in mail. r=#fluent-reviewers,#thunderbird-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ed4fdc3f75cd
Remove temporary mozFiveStar.ftl in mail. r=Paenglab

Comment 5

[Rob Wu [:robwu]]

The patch hasn't landed yet. What did land was just a revert of bug 1840086 ahead of landing the actual fix.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2297fba4069e
Move mozFiveStar.ftl to toolkit. r=fluent-reviewers,flod

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2297fba4069e

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1838041