Closed Bug 1840087 Opened 3 years ago Closed 3 years ago

NNTP message headers not shown

Categories

(Thunderbird :: Message Reader UI, defect)

Thunderbird 116
defect

Tracking

(thunderbird_esr102 unaffected, thunderbird115+ fixed)

RESOLVED FIXED
116 Branch
Tracking Status
thunderbird_esr102 --- unaffected
thunderbird115 + fixed

People

(Reporter: welpy-cw, Assigned: mkmelin)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [supernova3p])

Attachments

(1 file)

Usenet message headers are not shown anymore in the latest daily builds, while error console reports

Uncaught (in promise) NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED: JavaScript component does not have a method named: "isPending"'JavaScript component does not have a method named: "isPending"' when calling method: [nsIChannel::isPending]
    onStateChange chrome://messenger/content/msgHdrView.js:545
msgHdrView.js:545

This seems to be a regression from Bug 1819916, as putting

        if (request.isPending()) {
          await new Promise(resolve => setTimeout(resolve));
        }

in msgHdrView.js in a try block and immediately catching the error mitigates the problem.

Flags: needinfo?(mkmelin+mozilla)
Keywords: regression
Regressed by: 1819916
Component: Networking: NNTP → Message Reader UI
Product: MailNews Core → Thunderbird
Hardware: All → Unspecified
Blocks: sn-msglist
Severity: -- → S3
Whiteboard: [supernova3p]
Assignee: nobody → mkmelin+mozilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(mkmelin+mozilla)
Attachment #9340881 - Attachment description: Bug 1840087 - Implement more if nsIRequest in NntpChannel and ImapChannel. r=#thunderbird-reviewers → Bug 1840087 - Implement more of nsIRequest in NntpChannel and ImapChannel (to make nntp work again). r=#thunderbird-reviewers
Target Milestone: --- → 116 Branch

Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/93794e0e07a1
Implement more of nsIRequest in NntpChannel and ImapChannel (to make nntp work again). r=kaie

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

Comment on attachment 9340881 [details]
Bug 1840087 - Implement more of nsIRequest in NntpChannel and ImapChannel (to make nntp work again). r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1819916
User impact if declined: nntp messages not shown
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Attachment #9340881 - Flags: approval-comm-beta?

Comment on attachment 9340881 [details]
Bug 1840087 - Implement more of nsIRequest in NntpChannel and ImapChannel (to make nntp work again). r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9340881 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: