Closed Bug 1840350 Opened 2 years ago Closed 2 years ago

Remove unnecessary cx->isHelperThreadContext() check around stencil instantiation

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
117 Branch
Tracking Status
firefox117 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

We shouldn't be performing stencil instantiation off main thread now.
there's obsolete check for cx->isHelperThreadContext(), and maybe some more.

https://searchfox.org/mozilla-central/rev/d31e56f7b3c2c18b8071a7b2a2fb6b4e01e3d3e8/js/src/frontend/BytecodeCompiler.cpp#433-435,447

bool frontend::InstantiateStencils(JSContext* cx, CompilationInput& input,
                                   const CompilationStencil& stencil,
                                   CompilationGCOutput& gcOutput) {
...
  if (!cx->isHelperThreadContext()) {
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/db45d5ce5f2c Remove unnecessary cx->isHelperThreadContext() check around stencil instantiation. r=nbp
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: