1840732 - Make IWYU changes to the accessibility module

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement, P4)

Description

[Nathan LaPré]

The Include What You Use tool is a useful way to check which includes are unnecessary. Removing them generally improves build times and reduces clutter. I think we should go through the module and remove unnecessary includes, at least the low-hanging fruit. It'll likely be a bit challenging to get IWYU set up in our build environment, but we should be able to hack something together for actionable advice.

Comment 1

[Nathan LaPré]

Attachment: Bug 1840732 Part 1: Remove unnecessary includes from accessible/base, r?eeejay,morgan,Jamie

This commit removes unnecessary include directives from cpp files in the
accessible/base directory. These suggestions came from the Include What You Use
tool.

Comment 2

[Nathan LaPré]

Attachment: Bug 1840732 Part 2: Remove unnecessary includes from accessible/basetypes, r?eeejay,morgan,Jamie

This revision removes unnecessary include directives from cpp files in the
accessible/basetypes directory. These suggestions came from the Include What You
Use tool.

Depends on D182288

Comment 3

[Nathan LaPré]

Attachment: Bug 1840732 Part 3: Remove unnecessary includes from accessible/generic, r?eeejay,morgan,Jamie

This revision removes unnecessary include directives from cpp files in the
accessible/generic directory. These suggestions came from the Include What You
Use tool.

Depends on D182397

Comment 4

[Nathan LaPré]

Attachment: Bug 1840732 Part 4: Remove unnecessary includes from accessible/xpcom, r?eeejay,morgan,Jamie

This revision removes unnecessary include directives from cpp files in the
accessible/xpcom directory. These suggestions came from the Include What You
Use tool.

Depends on D182398

Comment 5

[Nathan LaPré]

Attachment: Bug 1840732 Part 5: Remove unnecessary includes from accessible/aom, r?eeejay,morgan,Jamie

This revision removes unnecessary include directives from cpp files in the
accessible/aom directory. These suggestions came from the Include What You Use
tool.

Depends on D182399

Comment 6

[Nathan LaPré]

Attachment: Bug 1840732 Part 6: Remove unnecessary includes from accessible/html, r?eeejay,morgan,Jamie

This revision removes unnecssary include directives from cpp files in the
accessible/html directory. These suggestions came from the Include What You Use
tool.

Depends on D182400

Comment 7

[Nathan LaPré]

Attachment: Bug 1840732 Part 7: Remove unnecessary includes from accessible/ipc, r?eeejay,morgan,Jamie

This revision removes unnecessary include directives from cpp files in the
accessible/ipc directory. These suggestions came from the Include What You Use
tool.

Note that this is probably not everything here. It needs to be checked again
after rebasing on the latest unification changes.

Depends on D182401

Comment 8

[Nathan LaPré]

Adding some see-also bugs of interest

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd29498c8b43
Part 1: Remove unnecessary includes from accessible/base, r=Jamie
https://hg.mozilla.org/integration/autoland/rev/74b0ddd87bf9
Part 2: Remove unnecessary includes from accessible/basetypes, r=Jamie
https://hg.mozilla.org/integration/autoland/rev/873ffb7ad802
Part 3: Remove unnecessary includes from accessible/generic, r=Jamie
https://hg.mozilla.org/integration/autoland/rev/60b2b5543d30
Part 4: Remove unnecessary includes from accessible/xpcom, r=Jamie
https://hg.mozilla.org/integration/autoland/rev/3e3d1d7be415
Part 5: Remove unnecessary includes from accessible/aom, r=Jamie
https://hg.mozilla.org/integration/autoland/rev/ff7bf50fe57b
Part 6: Remove unnecessary includes from accessible/html, r=Jamie
https://hg.mozilla.org/integration/autoland/rev/7f0f8b547e2a
Part 7: Remove unnecessary includes from accessible/ipc, r=Jamie

Comment 10

[Andi [:andi]]

This is a good effort but we should be very careful with this not removing direct includes that consist definition used in the translation units. We should rely on other headers that includes the headers that have definitions for used things in the TU.

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/fd29498c8b43
https://hg.mozilla.org/mozilla-central/rev/74b0ddd87bf9
https://hg.mozilla.org/mozilla-central/rev/873ffb7ad802
https://hg.mozilla.org/mozilla-central/rev/60b2b5543d30
https://hg.mozilla.org/mozilla-central/rev/3e3d1d7be415
https://hg.mozilla.org/mozilla-central/rev/ff7bf50fe57b
https://hg.mozilla.org/mozilla-central/rev/7f0f8b547e2a