1840867 - CFR 'icon_and_message' layout broken after `addon_recommendation` CFR is shown

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Punam Dahiya [:pdahiya]]

Attachment: Screen Shot 2023-06-28 at 8.30.10 AM.png

CFR default 'icon_and_message' layout is showing ratings section by default. This breaks all messages live with layout as 'icon_and_message'

https://experimenter.services.mozilla.com/nimbus/device-migration-existing-users-sumo-switch-device-cfr-rollout/summary

https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/OnboardingMessageProvider.jsm#81

This issue seems to happen in same session after a CFR message with layout addon_recommendation is shown and is replicable in Fx114 and could be possible fallout of Bug 1825658 fix

STR:

1. Open about:newtab#devtools and copy message with layout 'addon_recommendation' and hit Show
   https://experimenter.services.mozilla.com/nimbus/dictionary-addon-all-users/summary

2. Search for CFR message e.g CFR_FULL_VIDEO_SUPPORT_EN with layout as icon_and_message. Click Show

Expected Result
Icon and Message shouldn't show ratings section

Comment 1

[Punam Dahiya [:pdahiya]]

NI @jprickett @halemu to help narrow down the regression and fix. Thanks

Comment 2

[Jason Prickett]

@pdahiya Seems like we can't reproduce this on latest m-c. Possible that there was a breaking change that was reverted? Were there any other configuration steps that led to this bug?

Comment 3

[Punam Dahiya [:pdahiya]]

(In reply to Jason Prickett from comment #2)

@pdahiya Seems like we can't reproduce this on latest m-c. Possible that there was a breaking change that was reverted? Were there any other configuration steps that led to this bug?

@jprickett yes looks like to replicate , user should see a CFR with addon_recommendation layout in the same session. Just updated STR with this pre-req. Thanks

Comment 4

[hanna A]

Attachment: Bug 1840867 - CFR icon_and_message layout broken after `addon_recommendation` CFR is shown

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:lsmith, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4de8442be49
CFR icon_and_message layout broken after `addon_recommendation` CFR is shown r=omc-reviewers,aminomancer

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a4de8442be49

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-07-24 Nightly build on Windows 10.
Verified as fixed on Firefox 117.0b5(build ID: 20230808215502) and Nightly 118.0a1(build ID: 20230809213044) on Windows 10, macOS 12. Ubuntu 22.