1825658 - Modify "addon_recommendation" CFR template to support Facebook container experiment

Status: VERIFIED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Hanna Alemu [:hanna_a]]

Attachment: image.png

Modify the "addon_recommendation" CFR template to support the designs for the Facebook Container add-on experiment. This includes adding the Fox icon, and moving the 'by Mozilla' text next to the addon name instead of the current design which is below it.

https://www.figma.com/file/u5QpDrTIdwXRAqZFXUoktg/Recommendations-onboarding?node-id=246-3793&t=9y9NqCsXD5dVwkhk-0

Comment 1

[Hanna Alemu [:hanna_a]]

Attachment: Bug 1825658 - Modify "addon_recommendation" CFR template to support Facebook container experiment r=jprickett

Comment 2

[Hanna Alemu [:hanna_a]]

Screen Shot 2023-04-07 at 4.50.34 PM

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e054b7d5f984
Modify "addon_recommendation" CFR template to support Facebook container experiment r=jprickett,barret

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset e054b7d5f984 (Bug 1825658) for causing newtab failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=T4IDxICFTSGzzPIY5wNOig.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=e054b7d5f984a4ca7a24e2a0fee4505272f4f051

Log: https://treeherder.mozilla.org/logviewer?job_id=412321619&repo=autoland&lineNumber=222
bc https://treeherder.mozilla.org/logviewer?job_id=412320918&repo=autoland&lineNumber=8387

Backout: https://hg.mozilla.org/integration/autoland/rev/4078bf4e2a6d4806008838e8423f8f98e2eea37d

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0190f2ec730b
Modify "addon_recommendation" CFR template to support Facebook container experiment r=jprickett,barret

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0190f2ec730b

Comment 8

[Hanna Alemu [:hanna_a]]

Comment on attachment 9327293 [details]
Bug 1825658 - Modify "addon_recommendation" CFR template to support Facebook container experiment r=jprickett

Beta/Release Uplift Approval Request

• User impact if declined: The UI of the Facebook container Experiment won't match designs: https://www.figma.com/file/u5QpDrTIdwXRAqZFXUoktg/Recommendations-onboarding?node-id=495-9131&t=9yIhgMv1Tbt7cFzj-0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Test plan: https://phabricator.services.mozilla.com/D174844
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only changes the "addon_recommendation" CFR template which is currently not used by any messages.
• String changes made/needed: No
• Is Android affected?: No

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9327293 [details]
Bug 1825658 - Modify "addon_recommendation" CFR template to support Facebook container experiment r=jprickett

Approved for 113.0b5.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b73c79f540ed

Comment 11

[Simona Rosu [:srosu], Ecosystem QA]

This task was part of the work done on QA-1860 for which we sent a YELLOW sign-off. Considering this I am marking it as Verified.