1840887 - Port bug 1824420 to Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect)

Description

[Kai Engert [:KaiE:]]

We need to port bug 1824420 to Thunderbird, in order to fix the current build bustage.

Comment 1

[Kai Engert [:KaiE:]]

I have a working try build here:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=71d00d8254ddcec71f444f1b229ef10a80fc330f
which used an experimental patch.

We need to test if it actually created a working installer.

Comment 2

[Rob Lemley [:rjl]]

The changes in comment 2's try build include these lines:

!endif
+
+; Return value is saved to an unused variable to prevent the the error flag
+; from being set.
+Var /GLOBAL UnusedExecCatchReturn
+ExecWait '"$INSTDIR\${FileMainEXE}" --backgroundtask install' $UnusedExecCatchReturn
 SectionEnd

Thunderbird doesn't support background tasks (yet) so this should be fine to drop. (IIRC, --backgroundtask install will set up the Windows "cron" task to periodically run the actual background tasks.)

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Bug 1840887 - Port bug 1824420 to Thunderbird. r=rjl

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0f4f09b50a4a
Port bug 1824420 to Thunderbird. r=rjl

Comment 5

[Rob Lemley [:rjl]]

Comment on attachment 9341580 [details]
Bug 1840887 - Port bug 1824420 to Thunderbird. r=rjl

[Triage Comment]
Bug 1824420 is included in Firefox 115.1.0esr, this bug needs uplift to fix Windows builds.

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 115.1.0:
https://hg.mozilla.org/releases/comm-esr115/rev/6fe52e911449