1840935 - Stop using isGeneratedId/isOriginalId in favor of source.isOriginal

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

There is quite a few callsites still using isGeneratedId(sourceId) and isOriginalId(sourceId) whereas we can query source.isOriginal attribute to make the distinction.
It will be faster as that's a boolean instead of a string comparison.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1840935 - [devtools] Migrate getBreakpointForSource from sourceId to source.

This will help then get rid of isGeneratedId(sourceId).

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1840935 - [devtools] Move from isGeneratedId(source.id) to !source.isOriginal.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1840935 - [devtools] Move from isOriginalId(source.id) to !source.isOriginal.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5203cc3299d3
[devtools] Migrate getBreakpointForSource from sourceId to source. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/e2d4ccb61381
[devtools] Move from isGeneratedId(source.id) to !source.isOriginal. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/532ac41f7d99
[devtools] Move from isOriginalId(source.id) to !source.isOriginal. r=devtools-reviewers,bomsy

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5203cc3299d3
https://hg.mozilla.org/mozilla-central/rev/e2d4ccb61381
https://hg.mozilla.org/mozilla-central/rev/532ac41f7d99