1822310 - Revise "cx"/context "threadcx"/thread context assertion in the debugger

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

The debugger codebase inconsistently use assertions against either a "context" (cx) or a "thread context" (threadcx):

https://searchfox.org/mozilla-central/rev/dbec4165e4c26a0ff970b614842b689e8357593c/devtools/client/debugger/src/utils/context.js#32-58

These assertions are going to break bug 1806796.
These assertions explicitely prevents some actions from completing after NAVIGATE action is fired. This will break all these actions which will be fired for unload breakpoint as the breakpoint related to the previous context and the new one has been notified via NAVIGATE.

It means that we have to revise these assertions. Instead, we should make them become target/thread based. An async action should bailout if the related target/thread has been removed. But we should ignore navigation, as we may have meaningful actions going across navigation, typically anything around unload event.

We should probably find an API where the action declares its related target/thread,
and the middleware would automatically check if the target/thread is still valid before completing more async actions.

https://searchfox.org/mozilla-central/rev/dbec4165e4c26a0ff970b614842b689e8357593c/devtools/client/debugger/src/actions/utils/middleware/context.js#24-31

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Assume that pause always comes with a frame attribute.

Which is the case. The thread state resource is always emited with a related top frame actor.

Also clarify where does pausedInfo comes from.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Revise context assertions done on pause.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Add tests to cover breakpoints on unload.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Use a new "selected frame context" when fetching and mapping scopes.

The current "thread context" is too loose. These actions are specific to a given frame.
If we step to another frame, or select another frame in the call stack, we can cancel these async actions.

Comment 5

[Phabricator Automation]

Comment on attachment 9333112 [details]
Bug 1822310 - [devtools] Assume that pause always comes with a frame attribute.

Revision D177784 was moved to bug 1839192. Setting attachment 9333112 [details] to obsolete.

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Migrate updateExpressions to "selected frame or global context".

Stop storing context for expression actions as it sounds fine
trying to update the expression to whatever is the latest selected thread/frame.
That, instead of throwing if the current thread/frame is different from the one
original set when rendering the React component.

This is slightly more complex than fetch scopes actions
as expression aren't only evaluated on paused frames, but also against the global
scope of the target.

Removing a few jest test as they are testing more mocks than actual code
and poorly replicate correct state regarding selected thread/frame.

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Migrate setExpandedScope action to "selected frame context".

This action records the expanded path expanded in the scope panel.

While these paths are saved across pause/resume via lastExpandedScopes,
this action saves the data into expandedScopes which is specific to each paused/step location.

Also simplify scope selectors by passing only the frame object.
The frame object already has a reference to the related thread,
and the sourceId can be fetched late instead of being passed in all these functions.

Comment 8

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Stop passing context to selectFrame.

This isn't super useful. Instead we could verify in the reducer if the frame exists
and assert in the action that the frame was selected.

While doing this, fix the Frame component and stop passing new arrow function to <div>.
This force re-renderings.

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Use the context middleware to cancel outdated fetch and map scope actions.

The current "thread context" is too loose. These actions are specific to the currently selected frame.
If we step to another frame, or select another frame in the call stack, or select another thread, we can cancel these async actions.

But instead of using the "context" pattern, only identify the "selectedFrame" attribute passed
and ensure it is still relevant.

Also correctly await for async actions from selectFrame.

Comment 10

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Migrate updateExpressions to "selected frame or global context".

This is slightly more complex than "scopes" actions.
Expressions aren't only evaluated on paused frames,
but also against the global scope of the target.
So that we have to accept having a null selectedFrame.
The main special case here is that the action will either have selectedFrame or thread attribute set.

Removing a few jest test as they are testing more mocks than actual code
and poorly replicate correct state regarding selected thread/frame.

Comment 11

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Migrate setExpandedScope action to "selectedFrame" pattern.

This action records the expanded paths in the scope panel.

While these paths are saved across pause/resume via lastExpandedScopes,
this particular action saves the data into expandedScopes which is specific to each paused/step location.

Comment 12

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Move from "context" to breakpoint's location assertion for SET_BREAKPOINT action.

Focus on actions involving SET_BREAKPOINT and all its nested callsites.

Comment 13

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Move from "context" to breakpoint's location assertion for REMOVE_BREAKPOINT action.

Focus on actions involving REMOVE_BREAKPOINT

Comment 14

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Move from "context" to source assertion for setBreakpointPositions action.

Comment 15

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Move from "context" to breakpoint's location assertion for ADD_BREAKPOINT action.

Focus on actions involving ADD_BREAKPOINT.

While doing this, simplify loadSourceText,loadGeneratedSourceText,loadOriginalSourceText to pass source/sourceActor directly instead of a dictionary argument.
Also migrate LOAD_GENERATED_SOURCE_TEXT/LOAD_ORIGINAL_SOURCE_TEXT to assert source/sourceActor instead of using cx.
To do that, also start asserting "sourceActor" attributes of actions.

This removes the last usage of context for breakpoint related action
and we can remove lots of nested usage of context which were solely related to these actions...

Comment 16

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Move from "context" to source/sourceActor assertion for setBreakableLines action.

Comment 17

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Move from "context" to location assertion for setSymbols action.

Comment 18

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Move from "context" to location assertion for setInScopeLines action.

Comment 19

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Remove leftover "cx" variable from preview actions.

Comment 20

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Align breakOnNext and continueToHere with step and resume actions.

Step and resume actions (command action) are acting on the currently selected thread,
so that there is no need to pass a context. These actions could also query the selectors
to guess what is the currently selected thread.

Comment 21

[Phabricator Automation]

Comment on attachment 9342534 [details]
Bug 1822310 - [devtools] Remove leftover "cx" variable from preview actions.

Revision D182873 was moved to bug 1841967. Setting attachment 9342534 [details] to obsolete.

Comment 22

[Phabricator Automation]

Comment on attachment 9342535 [details]
Bug 1822310 - [devtools] Align breakOnNext and continueToHere with step and resume actions.

Revision D182874 was moved to bug 1841967. Setting attachment 9342535 [details] to obsolete.

Comment 23

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Align continueToHere with step and resume actions.

This is similar to D182874 and breakOnNext.

Comment 24

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Move from "context" to top frame assertion for mapDisplayNames action.

Removing some jest test not able to set correct location objects.
The mocks are lacking sourceActor attributes.

Comment 25

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Move from "context" to top frame assertion for fetch and map frames actions.

Comment 26

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Move from "context" to frame assertion for selectFrame action.

Here we should simply ensure that the frame is still valid.
Compared to selectedFrame we only want to check if the frame exists
and not that it is the currently selected one.

Rename frame to topFrame in PAUSED in order to avoid triggerring this assertion.
That other action is the action populating the first frame.

Comment 27

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Stop using context for restart action.

This action is a bit tricky. Ideally we would assert against the frame object,
but as this cause the server to resume execution, we would immediately
switch to a new pause location and frames would change.

It is probably easier to avoid trying to cancel this action.
When it executes, it first checks if frame's thread is paused,
then it also validates the frame argument.

Comment 28

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Move from "context" to source/sourceActor assertion for CLEAR_SOURCE_ACTOR_MAP_URL action.

Comment 29

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Move from "context" to generatedSourceActor assertion for ADD_ORIGINAL_SOURCES.

As we declare a related generated source actor, we can ensure it is still valid in the reducer.
The source actors are being removed on thread removal.

For ADD_SOURCES, it is harder to find a good assertion.
The current context assertion is useless as we fetch the "cx" just before dispatching the ADD_SOURCES action...
Anyway, this action is emitted synchronously from onResourceAvailable so that should be reliable.
The only check we could do would be to ensure that the thread which emitted these SOURCE resources
is still registered in the reducer, but that's a bit complex as wight be notified about sources
related to many threads (via ResourceCommand throttling).

Comment 30

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Move from "context" to location assertion for all location selection actions.

This one is the last and has lots of nested dependencies.

Comment 31

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Use regular resume() test helper in browser_dbg-blackbox.js.

The resume helper should wait correctly for any async work.
If not, it should be fixed instead.

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/427e2ccccc7d
[devtools] Use the context middleware to cancel outdated fetch and map scope actions. r=devtools-reviewers,bomsy

Comment 33

[Iulian Moraru]

Backed out for causing dt failures on browser_dbg-windowless-service-workers-reload.js.

• Push with failures

• Failure log

• Backout link

[task 2023-07-12T21:38:29.955Z] 21:38:29     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-windowless-service-workers-reload.js | a new breakpoint was created - 
[task 2023-07-12T21:38:29.956Z] 21:38:29     INFO - Invoking in tab: fetchFromWorker()
[task 2023-07-12T21:38:29.956Z] 21:38:29     INFO - Waiting for the debugger to pause
[task 2023-07-12T21:38:29.957Z] 21:38:29     INFO - Waiting for state change: paused
[task 2023-07-12T21:38:29.957Z] 21:38:29     INFO - Finished waiting for state change: paused
[task 2023-07-12T21:38:29.957Z] 21:38:29     INFO - Waiting for state change: fetched frames
[task 2023-07-12T21:38:29.958Z] 21:38:29     INFO - Buffered messages finished
[task 2023-07-12T21:38:29.961Z] 21:38:29     INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-windowless-service-workers-reload.js | Uncaught exception in test bound  - at resource://devtools/client/debugger/src/selectors/pause.js:154 - TypeError: can't access property "filter", frames is null
[task 2023-07-12T21:38:29.961Z] 21:38:29     INFO - Stack trace:
[task 2023-07-12T21:38:29.961Z] 21:38:29     INFO - getCurrentThreadFrames<@resource://devtools/client/debugger/src/selectors/pause.js:154:3
[task 2023-07-12T21:38:29.961Z] 21:38:29     INFO - createSelectorCreator/createSelector/memoizedResultFunc<@resource://devtools/client/shared/vendor/reselect.js:218:27
[task 2023-07-12T21:38:29.961Z] 21:38:29     INFO - memoized@resource://devtools/client/shared/vendor/reselect.js:129:22
[task 2023-07-12T21:38:29.961Z] 21:38:29     INFO - createSelectorCreator/createSelector/selector<@resource://devtools/client/shared/vendor/reselect.js:232:42
[task 2023-07-12T21:38:29.961Z] 21:38:29     INFO - memoized@resource://devtools/client/shared/vendor/reselect.js:129:22
[task 2023-07-12T21:38:29.961Z] 21:38:29     INFO - bindSelectors/</bound[selector]@resource://devtools/client/debugger/src/utils/dbg.js:34:59
[task 2023-07-12T21:38:29.962Z] 21:38:29     INFO - waitForState/<@chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/shared-head.js:78:18
[task 2023-07-12T21:38:29.962Z] 21:38:29     INFO - waitForState@chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/shared-head.js:76:10
[task 2023-07-12T21:38:29.962Z] 21:38:29     INFO - waitForPaused@chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/shared-head.js:563:9
[task 2023-07-12T21:38:29.962Z] 21:38:29     INFO - async*@chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/browser_dbg-windowless-service-workers-reload.js:26:9
[task 2023-07-12T21:38:29.962Z] 21:38:29     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1131:26
[task 2023-07-12T21:38:29.962Z] 21:38:29     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1203:18
[task 2023-07-12T21:38:29.962Z] 21:38:29     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14
[task 2023-07-12T21:38:29.962Z] 21:38:29     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1120:14
[task 2023-07-12T21:38:29.962Z] 21:38:29     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13
[task 2023-07-12T21:38:29.962Z] 21:38:29     INFO - Leaving test bound 
[task 2023-07-12T21:38:30.174Z] 21:38:30     INFO - Removing tab.
[task 2023-07-12T21:38:30.180Z] 21:38:30     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2023-07-12T21:38:30.185Z] 21:38:30     INFO - Got event: 'TabClose' on [object XULElement].
[task 2023-07-12T21:38:30.194Z] 21:38:30     INFO - Tab removed and finished closing
[task 2023-07-12T21:38:30.203Z] 21:38:30     INFO - GECKO(7056) | JavaScript error: , line 0: NotFoundError: No such JSWindowActor 'DevToolsFrame'
[task 2023-07-12T21:38:30.216Z] 21:38:30     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2023-07-12T21:38:30.217Z] 21:38:30     INFO - GECKO(7056) | JavaScript error: resource://devtools/shared/protocol/Front.js, line 106: Error: Connection closed, pending request to server0.conn0.content-process51/workerDescriptor6/thread1, type frames failed
[task 2023-07-12T21:38:30.218Z] 21:38:30     INFO - GECKO(7056) | Request stack:
[task 2023-07-12T21:38:30.218Z] 21:38:30     INFO - GECKO(7056) | request@resource://devtools/shared/protocol/Front.js:300:14
[task 2023-07-12T21:38:30.218Z] 21:38:30     INFO - GECKO(7056) | generateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:47:19
[task 2023-07-12T21:38:30.218Z] 21:38:30     INFO - GECKO(7056) | getFrames@resource://devtools/client/fronts/thread.js:82:18
[task 2023-07-12T21:38:30.222Z] 21:38:30     INFO - GECKO(7056) | getFrames@resource://devtools/client/debugger/src/client/firefox/commands.js:366:38
[task 2023-07-12T21:38:30.223Z] 21:38:30     INFO - GECKO(7056) | fetchFrames/<@resource://devtools/client/debugger/src/actions/pause/fetchFrames.js:24:29
[task 2023-07-12T21:38:30.223Z] 21:38:30     INFO - GECKO(7056) | thunk/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29:45
[task 2023-07-12T21:38:30.223Z] 21:38:30     INFO - GECKO(7056) | dispatch@resource://devtools/client/shared/vendor/redux.js:681:28
[task 2023-07-12T21:38:30.223Z] 21:38:30     INFO - GECKO(7056) | paused/<@resource://devtools/client/debugger/src/actions/pause/paused.js:62:11
[task 2023-07-12T21:38:30.224Z] 21:38:30     INFO - GECKO(7056) | thunk/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29:45
[task 2023-07-12T21:38:30.225Z] 21:38:30     INFO - GECKO(7056) | bindActionCreator/<@resource://devtools/client/shared/vendor/redux.js:520:12
[task 2023-07-12T21:38:30.225Z] 21:38:30     INFO - GECKO(7056) | onThreadStateAvailable@resource://devtools/client/debugger/src/client/firefox.js:183:21
[task 2023-07-12T21:38:30.225Z] 21:38:30     INFO - GECKO(7056) | async*_notifyWatchers@resource://devtools/shared/commands/resource/resource-command.js:871:24
[task 2023-07-12T21:38:30.225Z] 21:38:30     INFO - GECKO(7056) | later@resource://devtools/shared/throttle.js:33:19
[task 2023-07-12T21:38:30.225Z] 21:38:30     INFO - GECKO(7056) | notify@resource://gre/modules/Timer.sys.mjs:49:17
[task 2023-07-12T21:38:30.225Z] 21:38:30     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-windowless-service-workers-reload.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2023-07-12T21:38:30.228Z] 21:38:30     INFO - Console message: [JavaScript Error: "Failed to load . A ServiceWorker intercepted the request and encountered an unexpected error." {file: "https://example.com/browser/devtools/client/debugger/test/mochitest/examples/service-worker.sjs" line: 14}]
[task 2023-07-12T21:38:30.230Z] 21:38:30     INFO - Console message: [JavaScript Error: "Error: Connection closed, pending request to server0.conn0.content-process51/workerDescriptor6/thread1, type frames failed
[task 2023-07-12T21:38:30.230Z] 21:38:30     INFO - 
[task 2023-07-12T21:38:30.230Z] 21:38:30     INFO - Request stack:
[task 2023-07-12T21:38:30.231Z] 21:38:30     INFO - request@resource://devtools/shared/protocol/Front.js:300:14
[task 2023-07-12T21:38:30.231Z] 21:38:30     INFO - generateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:47:19
[task 2023-07-12T21:38:30.231Z] 21:38:30     INFO - getFrames@resource://devtools/client/fronts/thread.js:82:18
[task 2023-07-12T21:38:30.231Z] 21:38:30     INFO - getFrames@resource://devtools/client/debugger/src/client/firefox/commands.js:366:38
[task 2023-07-12T21:38:30.231Z] 21:38:30     INFO - fetchFrames/<@resource://devtools/client/debugger/src/actions/pause/fetchFrames.js:24:29
[task 2023-07-12T21:38:30.231Z] 21:38:30     INFO - thunk/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29:45
[task 2023-07-12T21:38:30.231Z] 21:38:30     INFO - dispatch@resource://devtools/client/shared/vendor/redux.js:681:28
[task 2023-07-12T21:38:30.231Z] 21:38:30     INFO - paused/<@resource://devtools/client/debugger/src/actions/pause/paused.js:62:11
[task 2023-07-12T21:38:30.231Z] 21:38:30     INFO - thunk/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29:45
[task 2023-07-12T21:38:30.231Z] 21:38:30     INFO - bindActionCreator/<@resource://devtools/client/shared/vendor/redux.js:520:12
[task 2023-07-12T21:38:30.231Z] 21:38:30     INFO - onThreadStateAvailable@resource://devtools/client/debugger/src/client/firefox.js:183:21
[task 2023-07-12T21:38:30.232Z] 21:38:30     INFO - async*_notifyWatchers@resource://devtools/shared/commands/resource/resource-command.js:871:24
[task 2023-07-12T21:38:30.232Z] 21:38:30     INFO - later@resource://devtools/shared/throttle.js:33:19
[task 2023-07-12T21:38:30.232Z] 21:38:30     INFO - notify@resource://gre/modules/Timer.sys.mjs:49:17
[task 2023-07-12T21:38:30.232Z] 21:38:30     INFO - " {file: "resource://devtools/shared/protocol/Front.js" line: 106}]
[task 2023-07-12T21:38:30.233Z] 21:38:30     INFO - GECKO(7056) | [Parent 2988, IPC I/O Parent] WARNING: DuplicateHandle failed for handle 0 in TransferHandles: file /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_win.cc:621
[task 2023-07-12T21:38:30.234Z] 21:38:30     INFO - GECKO(7056) | [GPU 10032, IPC I/O Child] WARNING: pipe error: 232: file /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_win.cc:443
[task 2023-07-12T21:38:30.582Z] 21:38:30     INFO - GECKO(7056) | MEMORY STAT | vsize 2113220MB | vsizeMaxContiguous 65089987MB | residentFast 723MB | heapAllocated 302MB
[task 2023-07-12T21:38:30.585Z] 21:38:30     INFO - TEST-OK | devtools/client/debugger/test/mochitest/browser_dbg-windowless-service-workers-reload.js | took 2662ms
[task 2023-07-12T21:38:30.596Z] 21:38:30     INFO - checking window state
[task 2023-07-12T21:38:30.604Z] 21:38:30     INFO - TEST-START | devtools/client/debugger/test/mochitest/browser_dbg-windowless-service-workers.js

Comment 34

[Alexandre Poirot [:ochameau]]

Seems to be fixed in the latest revision:
https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=INIwPSArSG2ebnp8D0cTdw.0&revision=a89c7d4c022aed77eb60f4eca7730203565e4d24

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c34244cc7cf5
[devtools] Use the context middleware to cancel outdated fetch and map scope actions. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/3091e86bf099
[devtools] Migrate updateExpressions to "selected frame or global context". r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/611c749c898f
[devtools] Migrate setExpandedScope action to "selectedFrame" pattern. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/c04429ac3e1a
[devtools] Move from "context" to breakpoint's location assertion for SET_BREAKPOINT action. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/bac1b1b00515
[devtools] Move from "context" to breakpoint's location assertion for REMOVE_BREAKPOINT action. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/0ed58729f441
[devtools] Move from "context" to source assertion for setBreakpointPositions action. r=devtools-reviewers,bomsy

Comment 36

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822310 - [devtools] Document all context middleware assertions.

Comment 37

[Narcis Beleuzu [:NarcisB]]

Backed out for damp failure on custom.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/5f6e606c18953417de5f8ac1e0acc13cab5df516
Log link: https://treeherder.mozilla.org/logviewer?job_id=422573179&repo=autoland&lineNumber=1695

Comment 38

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/cffa234d6dfe
Backed out 6 changesets for damp failure on custom.js

Comment 39

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37ad47bc8a2d
[devtools] Use the context middleware to cancel outdated fetch and map scope actions. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/638641e65069
[devtools] Migrate updateExpressions to "selected frame or global context". r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/4cd0a6d19f3f
[devtools] Migrate setExpandedScope action to "selectedFrame" pattern. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/22e827b2b2ce
[devtools] Move from "context" to breakpoint's location assertion for SET_BREAKPOINT action. r=devtools-reviewers,bomsy

Comment 40

[Iulian Moraru]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/5f6e606c1895

Comment 41

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/37ad47bc8a2d
https://hg.mozilla.org/mozilla-central/rev/638641e65069
https://hg.mozilla.org/mozilla-central/rev/4cd0a6d19f3f
https://hg.mozilla.org/mozilla-central/rev/22e827b2b2ce

Comment 42

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d11c3ae486aa
[devtools] Move from "context" to breakpoint's location assertion for REMOVE_BREAKPOINT action. r=devtools-reviewers,bomsy,perftest-reviewers,kshampur
https://hg.mozilla.org/integration/autoland/rev/86e174bda89a
[devtools] Move from "context" to source assertion for setBreakpointPositions action. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/0f7f67b13792
[devtools] Move from "context" to breakpoint's location assertion for ADD_BREAKPOINT action. r=devtools-reviewers,bomsy,perftest-reviewers,kshampur
https://hg.mozilla.org/integration/autoland/rev/167395be46a1
[devtools] Move from "context" to source/sourceActor assertion for setBreakableLines action. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/d936f00c8296
[devtools] Align continueToHere with step and resume actions. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/5f6276ae93a4
[devtools] Move from "context" to location assertion for setSymbols action. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/2471a29a9e41
[devtools] Move from "context" to location assertion for setInScopeLines action. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/822b87c44e29
[devtools] Move from "context" to top frame assertion for mapDisplayNames action. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/68c047de6103
[devtools] Move from "context" to top frame assertion for fetch and map frames actions. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/c2b5ed240be2
[devtools] Move from "context" to frame assertion for selectFrame action. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/2c2ee353412f
[devtools] Stop using context for restart action. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/47208ffa2647
[devtools] Move from "context" to source/sourceActor assertion for CLEAR_SOURCE_ACTOR_MAP_URL action. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/cfc433febf5b
[devtools] Move from "context" to generatedSourceActor assertion for ADD_ORIGINAL_SOURCES. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/1733a94650da
[devtools] Move from "context" to location assertion for all location selection actions. r=devtools-reviewers,bomsy,perftest-reviewers,kshampur
https://hg.mozilla.org/integration/autoland/rev/a668cdc3e6ea
[devtools] Use regular resume() test helper in browser_dbg-blackbox.js. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/038e656bb933
[devtools] Document all context middleware assertions. r=bomsy,devtools-reviewers

Comment 43

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d11c3ae486aa
https://hg.mozilla.org/mozilla-central/rev/86e174bda89a
https://hg.mozilla.org/mozilla-central/rev/0f7f67b13792
https://hg.mozilla.org/mozilla-central/rev/167395be46a1
https://hg.mozilla.org/mozilla-central/rev/d936f00c8296
https://hg.mozilla.org/mozilla-central/rev/5f6276ae93a4
https://hg.mozilla.org/mozilla-central/rev/2471a29a9e41
https://hg.mozilla.org/mozilla-central/rev/822b87c44e29
https://hg.mozilla.org/mozilla-central/rev/68c047de6103
https://hg.mozilla.org/mozilla-central/rev/c2b5ed240be2
https://hg.mozilla.org/mozilla-central/rev/2c2ee353412f
https://hg.mozilla.org/mozilla-central/rev/47208ffa2647
https://hg.mozilla.org/mozilla-central/rev/cfc433febf5b
https://hg.mozilla.org/mozilla-central/rev/1733a94650da
https://hg.mozilla.org/mozilla-central/rev/a668cdc3e6ea
https://hg.mozilla.org/mozilla-central/rev/038e656bb933

Comment 44

[Julian Descottes [:jdescottes]]

== Change summary for alert #39032 (as of Sun, 16 Jul 2023 16:39:57 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
33%	reload-debugger:parent-process objects-with-stacks	linux1804-64-qr		20.77 -> 14.00

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39032

Comment 45

[Mathew Hodson]

Can this bug be closed? It looks like all the patches landed in Firefox 117.

Comment 46

[Alexandre Poirot [:ochameau]]

Oh yes, good catch!
I forgot to close it when removing the leave-info.

Comment 47

[Phabricator Automation]

Comment on attachment 9333114 [details]
Bug 1822310 - [devtools] Add tests to cover breakpoints on unload.

Revision D177786 was moved to bug 1806796. Setting attachment 9333114 [details] to obsolete.