Cosmetic fix to WPTs css/css-flexbox/alignment/flex-align-baseline-table-*
Categories
(Core :: Layout: Flexbox, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox116 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
While triaging WPT failures, I noticed these WPTs have results tables that have a pink background with broken content if you expand the "Asserts run" section:
http://wpt.live/css/css-flexbox/alignment/flex-align-baseline-table-001.html
http://wpt.live/css/css-flexbox/alignment/flex-align-baseline-table-002.html
http://wpt.live/css/css-flexbox/alignment/flex-align-baseline-table-003.html
This is because some of the test CSS is getting applied to the results table. I initially filed https://github.com/web-platform-tests/wpt/issues/40796 to fix it upstream, but it's easier for me to just fix it here and let wpt bot handle the merge, so I'm going to do that.
(The fix is uncontroversial, since it's not functionally changing the test.)
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Comment 1•1 year ago
|
||
This is a trivial cosmetic fix to some WPTs, whose table-related CSS rules were
inadvertently targeting the dynamically-appended results table, which meant
that parts of the the test results were unreadable.
This patch is just putting all of the style rules for table parts behind a
.target descendant selector. This lets those rules continue to match the
test content, without also matching the results table.
This fixes https://github.com/web-platform-tests/wpt/issues/40796
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/46adaf6104b5 Fix WPTs flex-align-baseline-table-* so their style rules don't apply to their table of test results. r=TYLin
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40824 for changes under testing/web-platform/tests
|
||
Comment 4•1 year ago
|
||
| bugherder | ||
Upstream PR merged by moz-wptsync-bot
Description
•