Closed Bug 1848445 Opened 11 months ago Closed 10 months ago

Cosmetic fix to WPTs css/css-grid/alignment/grid-align-baseline-table-*

Categories

(Core :: Layout: Grid, task)

task

Tracking

()

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: dholbert, Assigned: TYLin)

References

Details

Attachments

(1 file)

This is like bug 1840952 but for the analogous grid tests.

These WPTs have results tables that have a pink background with broken content if you expand the "Asserts run" section:
http://wpt.live/css/css-grid/alignment/grid-align-baseline-table-001.html
http://wpt.live/css/css-grid/alignment/grid-align-baseline-table-002.html
http://wpt.live/css/css-grid/alignment/grid-align-baseline-table-003.html

This is because some of the test CSS is getting applied to the results table, as described in bug 1840952. We can fix that by just making the test CSS a bit more specific.

Summary: Cosmetic fix to WPTs css/css-flexbox/alignment/flex-align-baseline-table-* → Cosmetic fix to WPTs css/css-grid/alignment/grid-align-baseline-table-*
See Also: → 1848446
Assignee: dholbert → aethanyc

Similar to bug 1840952, this patch is just putting all the style rules behind a
.target descendant selector in order to prevent them from matching the results
table.

Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/44ba8ebd6477
Fix WPTs so that their style rules don't apply to their table of test results. r=dholbert
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41507 for changes under testing/web-platform/tests
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: