Closed Bug 1840981 Opened 2 years ago Closed 2 months ago

Intermittent netwerk/test/unit/test_http3_dns_retry.js | single tracking bug

Categories

(Core :: Networking, defect, P2)

defect

Tracking

()

RESOLVED FIXED
135 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- disabled
firefox-esr128 --- wontfix
firefox115 --- unaffected
firefox116 --- disabled
firefox117 --- disabled
firefox118 --- disabled
firefox133 --- wontfix
firefox134 --- fixed
firefox135 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: kershaw)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression, Whiteboard: [stockwell disabled][necko-triaged])

Attachments

(3 files, 1 obsolete file)

Filed by: chorotan [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=421029582&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/fcYvTyUXQdihpzQaJZVOXg/runs/0/artifacts/public/logs/live_backing.log


task 2023-06-29T02:37:37.192Z] 02:37:37     INFO -  TEST-START | netwerk/test/unit/test_http3_dns_retry.js
[task 2023-06-29T02:38:07.898Z] 02:38:07  WARNING -  TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_http3_dns_retry.js | xpcshell return code: 0
[task 2023-06-29T02:38:07.898Z] 02:38:07     INFO -  TEST-INFO took 30705ms
[task 2023-06-29T02:38:07.898Z] 02:38:07     INFO -  >>>>>>>
[task 2023-06-29T02:38:07.898Z] 02:38:07     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2023-06-29T02:38:07.898Z] 02:38:07     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2023-06-29T02:38:07.898Z] 02:38:07     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2023-06-29T02:38:07.898Z] 02:38:07     INFO -  running event loop
[task 2023-06-29T02:38:07.898Z] 02:38:07     INFO -  netwerk/test/unit/test_http3_dns_retry.js | Starting setup setup
[task 2023-06-29T02:38:07.898Z] 02:38:07     INFO -  (xpcshell/head.js) | test setup pending (2)
[task 2023-06-29T02:38:07.898Z] 02:38:07     INFO -  TEST-PASS | netwerk/test/unit/test_http3_dns_retry.js | setup - [setup : 24] "35957" != null
[task 2023-06-29T02:38:07.898Z] 02:38:07     INFO -  TEST-PASS | netwerk/test/unit/test_http3_dns_retry.js | setup - [setup : 25] "35957" != ""
[task 2023-06-29T02:38:07.899Z] 02:38:07     INFO -  TEST-PASS | netwerk/test/unit/test_http3_dns_retry.js | setup - [setup : 28] "56859" != null
[task 2023-06-29T02:38:07.899Z] 02:38:07     INFO -  TEST-PASS | netwerk/test/unit/test_http3_dns_retry.js | setup - [setup : 29] "56859" != ""
[task 2023-06-29T02:38:07.902Z] 02:38:07     INFO -  PID 5131 | start!
[task 2023-06-29T02:38:07.902Z] 02:38:07     INFO -  TEST-PASS | netwerk/test/unit/test_http3_dns_retry.js | setup - [setup : 31] "35957" != null
[task 2023-06-29T02:38:07.903Z] 02:38:07     INFO -  TEST-PASS | netwerk/test/unit/test_http3_dns_retry.js | setup - [setup : 31] "35957" != ""
[task 2023-06-29T02:38:07.904Z] 02:38:07     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2023-06-29T02:38:07.904Z] 02:38:07     INFO -  "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
[task 2023-06-29T02:38:07.905Z] 02:38:07     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2023-06-29T02:38:07.905Z] 02:38:07     INFO -  (xpcshell/head.js) | test setup finished (2)
[task 2023-06-29T02:38:07.906Z] 02:38:07     INFO -  netwerk/test/unit/test_http3_dns_retry.js | Starting test_retry_with_ipv4
[task 2023-06-29T02:38:07.907Z] 02:38:07     INFO -  (xpcshell/head.js) | test test_retry_with_ipv4 pending (2)
[task 2023-06-29T02:38:07.907Z] 02:38:07     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2023-06-29T02:38:07.908Z] 02:38:07     INFO -  PID 5131 | console.error: (new Error("Unexpected content-type \\"text/plain;charset=US-ASCII\\"", "resource://services-settings/Utils.sys.mjs", 399))
[task 2023-06-29T02:38:07.908Z] 02:38:07     INFO -  Could not get contentLength
[task 2023-06-29T02:38:07.909Z] 02:38:07     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/netwerk/test/unit/head_channels.js:onStartRequest:111
[task 2023-06-29T02:38:07.910Z] 02:38:07     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:237
[task 2023-06-29T02:38:07.910Z] 02:38:07     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:584
[task 2023-06-29T02:38:07.911Z] 02:38:07     INFO -  -e:null:1
[task 2023-06-29T02:38:07.911Z] 02:38:07     INFO -  exiting test
[task 2023-06-29T02:38:07.912Z] 02:38:07     INFO -  Error in onStartRequest: [Exception... "Abort"  nsresult: "0x80004004 (NS_ERROR_ABORT)"  location: "JS frame :: /builds/worker/workspace/build/tests/xpcshell/head.js :: _abort_failed_test :: line 857"  data: no]
[task 2023-06-29T02:38:07.913Z] 02:38:07     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/netwerk/test/unit/head_channels.js:onStartRequest:144
[task 2023-06-29T02:38:07.913Z] 02:38:07     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:237
[task 2023-06-29T02:38:07.914Z] 02:38:07     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:584
[task 2023-06-29T02:38:07.914Z] 02:38:07     INFO -  -e:null:1
[task 2023-06-29T02:38:07.915Z] 02:38:07     INFO -  exiting test
[task 2023-06-29T02:38:07.915Z] 02:38:07     INFO -  PID 5131 | JavaScript error: /builds/worker/workspace/build/tests/xpcshell/head.js, line 857: NS_ERROR_ABORT:
[task 2023-06-29T02:38:07.916Z] 02:38:07     INFO -  Failed to load URL: 804b000d
[task 2023-06-29T02:38:07.916Z] 02:38:07     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/netwerk/test/unit/head_channels.js:onStopRequest:213
[task 2023-06-29T02:38:07.917Z] 02:38:07     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:237
[task 2023-06-29T02:38:07.918Z] 02:38:07     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:584
[task 2023-06-29T02:38:07.918Z] 02:38:07     INFO -  -e:null:1
[task 2023-06-29T02:38:07.919Z] 02:38:07     INFO -  exiting test
[task 2023-06-29T02:38:07.919Z] 02:38:07     INFO -  Error in onStopRequest: [Exception... "Abort"  nsresult: "0x80004004 (NS_ERROR_ABORT)"  location: "JS frame :: /builds/worker/workspace/build/tests/xpcshell/head.js :: _abort_failed_test :: line 857"  data: no]
[task 2023-06-29T02:38:07.920Z] 02:38:07     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/netwerk/test/unit/head_channels.js:onStopRequest:232
[task 2023-06-29T02:38:07.920Z] 02:38:07     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:237
[task 2023-06-29T02:38:07.921Z] 02:38:07     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:584
[task 2023-06-29T02:38:07.921Z] 02:38:07     INFO -  -e:null:1
[task 2023-06-29T02:38:07.922Z] 02:38:07     INFO -  exiting test
Duplicate of this bug: 1840982

Hi Kershaw! Can you please take a look at this?
Thank you!

Flags: needinfo?(kershaw)
Keywords: regression
Regressed by: 1816677

Set release status flags based on info from the regressing bug 1816677

Pushed by chorotan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/08125141741a disable test_http3_dns_retry.js for causing perma failures. r=RyanVM

Disabled the test for causing perma failures from https://bugzilla.mozilla.org/show_bug.cgi?id=1847066

Flags: needinfo?(kershaw)
Keywords: leave-open
Whiteboard: [stockwell disabled]

I think the test is slightly racy.
It fails with Could not get contentLength so maybe we're connecting to the wrong server?

Flags: needinfo?(kershaw)

I think we just need to set the "network.dns.get-ttl" pref to false like we did in bug 1760121

Priority: P5 → P2
Whiteboard: [stockwell disabled] → [stockwell disabled][necko-triaged]
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/757637299e51 Set network.dns.get-ttl to false, r=necko-reviewers,valentin

Forgot to clear the ni in commrent #20.

Flags: needinfo?(kershaw)
Attachment #9387461 - Attachment is obsolete: true

The recent increase in failure rate is caused by bug 1916418.
The issue lies in HTTPSRecordResolver::OnLookupComplete, where I assumed that the DNS request for the HTTPS RR would always complete before the request for the CNAME, which isn’t always true. If the CNAME request finishes before the HTTPS RR request, the callback is invoked with null records.

Assignee: nobody → kershaw
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4909efd94a9b Fix race condition in HTTPSRecordResolver::OnLookupComplete, r=necko-reviewers,valentin

Closing this as we dont see after kershaw's patch was merged

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch

The patch landed in nightly and beta is affected.
:kershaw, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(kershaw)
Attachment #9442670 - Flags: approval-mozilla-beta?

beta Uplift Approval Request

  • User impact if declined: HTTPS record may not be used.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: N/A
  • Risk associated with taking this patch: Low
  • Explanation of risk level: Already verified on Nightly.
  • String changes made/needed: N/A
  • Is Android affected?: yes
Attachment #9442670 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: needinfo?(kershaw)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: