1841045 - Automatic popup sometimes shows up on pages in a language in the list of "never translate from" languages

Status: VERIFIED FIXED

(Firefox :: Translations, defect)

Description

[Marco Castelluccio [:marco]]

When loading https://connect.mozilla.org/t5/ideas/reader-mode-for-pdf-files/idi-p/9908, the automatic popup is opened even though I set "English" to never be translated.

Comment 1

[Greg Tatum [:gregtatum]]

Hmmm... I'm not reproducing.

Comment 2

[Marco Castelluccio [:marco]]

I can reproduce when opening the tab right after starting Firefox. I can't reproduce if I wait a bit before opening the tab. I wonder if it's a racy behavior (e.g. maybe we get the prefs asynchronously and in the meantime we open the prompt without waiting for the prefs to be loaded).
Let me know how I can help, I can reproduce pretty consistently.

The easiest way to reproduce is:

1. Open a few tabs (just so session restore takes longer)
2. Open https://connect.mozilla.org/t5/ideas/reader-mode-for-pdf-files/idi-p/9908
3. Open a new blank tab and make sure it is selected before closing Firefox
4. Close and reopen Firefox
5. Select the https://connect.mozilla.org/t5/ideas/reader-mode-for-pdf-files/idi-p/9908 tab

I can't reproduce as easily if I have https://connect.mozilla.org/t5/ideas/reader-mode-for-pdf-files/idi-p/9908 selected before closing and reopening Firefox.

I can also reproduce with other pages such as https://www.theguardian.com/.

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1841045 - Fix race condition for offering the translations popup; r?nordzilla!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40dbf63260e2
Fix race condition for offering the translations popup; r=nordzilla

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/40dbf63260e2

Comment 7

[Marco Castelluccio [:marco]]

I can verify this is indeed fixed.

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-06-29 Nightly build(es-ES locale) on Windows 10.
Verified as fixed on Firefox 117.0b9(build ID: 20230817175856) and Nightly 118.0a1(build ID: 20230817214619) on Windows 10, macOS 12, Ubuntu 22.