1841887 - When restarting Firefox a translation is proposed for a website I added in the deny list

Status: RESOLVED FIXED

(Firefox :: Translations, defect)

Description

[Calixte Denizet (:calixte)]

I disabled translations for gmail which is in a pinned tab.
And when I restarted Firefox, a translation is proposed but when I click on the parameter wheel I can see that Never translate this site is already checked.

Comment 1

[Marco Castelluccio [:marco]]

Might be the same root cause as bug 1841045.

Comment 2

[Calixte Denizet (:calixte)]

I think I've a reliable way to reproduce it (note that I've around 40 pinned tabs).
After I restarted Firefox, if I click on the gmail pinned tab when it's loading then I get the popup but if I click once it's loaded then no popup.

Comment 3

[Marco Castelluccio [:marco]]

This is similar to what I'm doing to reproduce in bug 1841045.
I can also reproduce randomly while navigating, but it always seems related to some page being in the loading phase.

Comment 4

[Greg Tatum [:gregtatum]]

I found it, it's a race condition.

    browser.dispatchEvent(
      new CustomEvent("TranslationsParent:OfferTranslation", {
        bubbles: true,
      })
    );

This event needs to double check that it's still on the current tab.

Comment 5

[Greg Tatum [:gregtatum]]

This should be fixed by Bug 1841045.

Comment 6

[Marco Castelluccio [:marco]]

Calixte, could you verify this is fixed in latest Nightly?

Comment 7

[Calixte Denizet (:calixte)]

Yep it works fine.
But (sorry there's a but), now the icon in the toolbar is no more here which means that if I want to be able to translate it (because I changed my mind or just punctually) I don't know where I can do that.

Comment 8

[Greg Tatum [:gregtatum]]

That doesn't sound right. Adding a NI to myself to investigate.

Comment 9

[Greg Tatum [:gregtatum]]

Calixte: Can you provide a steps to reproduce and verify the icon is still hidden in your case? I suspect you are reporting an older behavior. I changed the behavior when we added automatic popup offerings so that when you chose "never translate" it only doesn't popup the menu, but it will still show the icon. In addition, "Translate page..." is available from the hamburger menu when you still need to manually invoke it.

Comment 10

[Calixte Denizet (:calixte)]

I removed French from Webpage Language Settings, and everything is ok.