1841049 - Serialize a context property for WindowProxy

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As per a recent change in the WebDriver BiDi specification the serialization of a WindowProxy has to include a context field.

Let window be the value of value’s [[WindowProxy]] internal slot.

Let browsing context be window’s browsing context.

Let context id be the browsing context id for browsing context.

Let serialized be a map matching the script.WindowProxyProperties production in the local end definition with the context property set to context id.

See also bug 1274251 for the required implementation in Marionette.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It's unlikely that this will make it into M8. Moving to M9.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The Marionette implementation is done now via bug 1274251. But we do not have the wdspec tests yet which will be synced via bug 1849891.

Also I noticed that for a better interop with classic we might want to have another field on the script.WindowProxyRemoteValue type that would indicate if it is a (top-level) window or a frame. Otherwise it will make it harder for the clients to build the correct WebFrame or WebWindow type for classic.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I've filed https://github.com/w3c/webdriver-bidi/issues/580. We potentially should wait with our implementation until this proposal has been discussed.

Comment 4

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1841049 - [bidi] Serialize a context property for WindowProxy.

Comment 5

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1841049 - Add gecko specific tests for serialization of a context property for WindowProxy.

Depends on D192703

Comment 6

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1841049 - [wdspec] Update WindowProxy serialization/deserialization tests for "context" field.

Depends on D192704

Comment 7

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1841049 - [wdspec] Add interop tests for window reference.

Depends on D192705

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4e5009e96b6
[bidi] Serialize a context property for WindowProxy. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/db635dee1440
Add gecko specific tests for serialization of a context property for WindowProxy. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/a6ec7bc1e873
[wdspec] Update WindowProxy serialization/deserialization tests for "context" field. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/1713e8a475fd
[wdspec] Add interop tests for window reference. r=webdriver-reviewers,whimboo

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43026 for changes under testing/web-platform/tests

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/f4e5009e96b6
https://hg.mozilla.org/mozilla-central/rev/db635dee1440
https://hg.mozilla.org/mozilla-central/rev/a6ec7bc1e873
https://hg.mozilla.org/mozilla-central/rev/1713e8a475fd

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot