Closed Bug 1841049 Opened 10 months ago Closed 5 months ago

Serialize a context property for WindowProxy

Categories

(Remote Protocol :: WebDriver BiDi, task, P2)

task
Points:
5

Tracking

(firefox121 fixed)

RESOLVED FIXED
121 Branch
Tracking Status
firefox121 --- fixed

People

(Reporter: whimboo, Assigned: Sasha)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [webdriver:m9][wptsync upstream][webdriver:relnote])

Attachments

(4 files)

As per a recent change in the WebDriver BiDi specification the serialization of a WindowProxy has to include a context field.

Let window be the value of value’s [[WindowProxy]] internal slot.

Let browsing context be window’s browsing context.

Let context id be the browsing context id for browsing context.

Let serialized be a map matching the script.WindowProxyProperties production in the local end definition with the context property set to context id.

See also bug 1274251 for the required implementation in Marionette.

Depends on: 1837031
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Assignee: aborovova → nobody
Status: ASSIGNED → NEW

It's unlikely that this will make it into M8. Moving to M9.

Whiteboard: [webdriver:m8] → [webdriver:m9]

The Marionette implementation is done now via bug 1274251. But we do not have the wdspec tests yet which will be synced via bug 1849891.

Also I noticed that for a better interop with classic we might want to have another field on the script.WindowProxyRemoteValue type that would indicate if it is a (top-level) window or a frame. Otherwise it will make it harder for the clients to build the correct WebFrame or WebWindow type for classic.

Depends on: 1849891

I've filed https://github.com/w3c/webdriver-bidi/issues/580. We potentially should wait with our implementation until this proposal has been discussed.

Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Attachment #9361877 - Attachment description: Bug 1841049 - [wdspec] Fix existing tests for WindowProxy. → Bug 1841049 - [wdspec] Update WindowProxy serialization/deserialization tests for "context" field.
Blocks: 1863505
Blocks: 1849891
No longer depends on: 1849891
No longer blocks: 1849891
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4e5009e96b6
[bidi] Serialize a context property for WindowProxy. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/db635dee1440
Add gecko specific tests for serialization of a context property for WindowProxy. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/a6ec7bc1e873
[wdspec] Update WindowProxy serialization/deserialization tests for "context" field. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/1713e8a475fd
[wdspec] Add interop tests for window reference. r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43026 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m9] → [webdriver:m9], [wptsync upstream]
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m9], [wptsync upstream] → [webdriver:m9][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: