1841142 - `GPUBuffer.unmap` should not yield an error when buffer is invalid

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect, P1)

Description

[Erich Gubler [:ErichDonGubler]]

Relevant link: https://github.com/gpuweb/cts/issues/1930

Steps to reproduce

1. Build Firefox off changes from bug 1840179 or later.

2. Run webgpu:api,operation,buffers,map:mappedAtCreation,mapState:* test cases from WebGPU's CTS. Observe that an extra validation error is thrown when buffer.unmap is called in the test's source.

   For convenience, the above can be automated with this mach command:

   ./mach wpt webgpu:api,operation,buffers,map:mappedAtCreation,mapState:*
   

Note that while the above repro. steps are based on bug 1840179, this bug existed before then.

Comment 1

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1841142: fix(webgpu): don't return an error for `GPUBuffer.unmap` when `this.[[device]]` is invalid r?#webgpu-reviewers

Depends on D182103

Comment 2

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1841142: fix(webgpu): don't return an error for `GPUBuffer.unmap` when `this` is invalid r?#webgpu-reviewers

Depends on D183052

Comment 3

[Phabricator Automation]

Comment on attachment 9342836 [details]
Bug 1841142: fix(webgpu): don't return an error for GPUBuffer.unmap when this.[[device]] is invalid r?#webgpu-reviewers

Revision D183052 was moved to bug 1838693. Setting attachment 9342836 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfdc3fbce9b4
fix(webgpu): don't return an error for `GPUBuffer.unmap` when `this` is invalid r=webgpu-reviewers,nical

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/dfdc3fbce9b4