Closed Bug 1842297 Opened 3 years ago Closed 1 month ago

Upstream tolerance of invalid buffer in `GPUBuffer.unmap` to WGPU

Categories

(Core :: Graphics: WebGPU, task, P2)

Product:
Core
Component:
Graphics: WebGPU
Type:
task

Tracking

()

Status:
RESOLVED MOVED
Tracking Flags:
Tracking Status
firefox117 --- affected

People

(Reporter: ErichDonGubler, Unassigned)

References

(Blocks 1 open bug)

Details

Now that the bleeding has stopped, per se, with the fix for bug 1841142, we'd like to upstream it to WGPU (since everybody should have it!). This should be pretty easy; it only requires the alteration of this line in wgpu_core::device::global.

Severity: S3 → --
Type: defect → task
Blocks: webgpu-triage

Regarding this comment:

NOTE: This is presumed by CTS test cases, and was even formally specified in the
WebGPU spec. previously, but this doesn't seem formally specified now. :confused:

This is specified in spec by Step 1 on device timeline at https://www.w3.org/TR/webgpu/#dom-gpubuffer-unmap:

  1. If any of the following conditions are unsatisfied, return.
    this is valid to use with this.[[device]].

Even more, unmap never fails/returns error on device timeline.

This will be resolved upstream by https://github.com/gfx-rs/wgpu/pull/10242.

Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → MOVED
You need to log in before you can comment on or make changes to this bug.