1841186 - In preferences "New Windows | Custom URLs" section, the "Use Current Pages" button has an awkward linewrap

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot

STR:

1. Visit about:preferences and click "Home" on the left
2. For "Homepage and new windows": choose "Custom URLs..." from the dropdown.
3. Look at the buttons that appear.

ACTUAL RESULTS:
The text for the "Use Current Pages" button barely doesn't fit on a single line and has a linebreak before "Pages". (This is true even if my window is arbitrarily large.)

EXPECTED RESULTS:
No such awkward linebreak (at least, not at default/generous window sizes).

This is a regression; Nightly 2023-01-01 places the button label on a single line (no linebreak). I'll track down the regression range shortly...

Comment 1

[Daniel Holbert [:dholbert]]

I'm using Nightly 116.0a1 (2023-06-29) (64-bit) on Ubuntu 22.04, BTW. (Not sure if this is platform-specific or not.)

Comment 2

[Daniel Holbert [:dholbert]]

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2cc925315ab4bc13d89167646695eece8d6f6a63&tochange=b50655fcce3faf31b2c1779c263ac7c1bca94863

--> Regression by the fix for bug 1822578

Comment 3

[Daniel Holbert [:dholbert]]

So it looks like that patch started making us distribute space more equally (setting flex-basis to 0 for some elements), and that's causing the trouble here, at two levels:

(1) Top level, dividing up space between the Homepage and new windows label vs. the vbox container of buttons/etc. to its right
(2) At the level of the two side-by-side buttons (Use Current Pages vs Use Bookmark)

Before and after the regression, this whole section is 672px wide.

But, for level (1):
Before the regression, the Homepage and new windows label had less width than its vbox sibling (which got the lion's share, 393px).
After the regression, the label and its vbox sibling both get 332px.

(So this means we have less space to distribute to the buttons.)

For level (2):
Before the regression, we were distributing the space that we had unequally -- "Use Current Pages" got 199.4px, vs. "Use Bookmark" got 186.4.
After the regression, we're distributing the space equally; both buttons get 162px. (And this is substantially less than we had before, since there's less space to distribute here, per level (1).)

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: Screenshot of #homepageGroup just after the regression

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: Screenshot of #homepageGroup just before the regression

Comment 6

[Daniel Holbert [:dholbert]]

If you compare those last two screenshots side-by-side tabs, you can see how the whole section got skinnier.

[Tentatively setting ni=emilio in case there's an obvious fix or approach to follow from another similar bug that he fixed. Not sure if we just want to use a content-based flex-basis here, or something else.)

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1841186 - Ensure homepage and new tabs menulists align. r=#preferences-reviewers

By simplifying the markup a bit.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1841186 - Ensure that if there's room for both homepage button texts, they fit without line-wrapping. r=#preferences-reviewers

Depends on D182662

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3e09bd1a670
Ensure homepage and new tabs menulists align. r=settings-reviewers,mconley
https://hg.mozilla.org/integration/autoland/rev/31bb0043b157
Ensure that if there's room for both homepage button texts, they fit without line-wrapping. r=settings-reviewers,mconley

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a3e09bd1a670
https://hg.mozilla.org/mozilla-central/rev/31bb0043b157

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox116 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Minor cosmetic fix, probably not worth uplifting.

Comment 13

[Gabi Cheta [:Gabi] Desktop QA]

Verified as fixed with Win 10x64, macOS 13 and Ubuntu 18.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Seems like a low-risk polish fix to take for ESR115 and it grafts cleanly. Do you want to nominate this for uplift?

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9342090 [details]
Bug 1841186 - Ensure homepage and new tabs menulists align. r=#preferences-reviewers

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: low risk cosmetic fix
• User impact if declined: comment 0
• Fix Landed on Version: 117
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple CSS fix.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9342090 [details]
Bug 1841186 - Ensure homepage and new tabs menulists align. r=#preferences-reviewers

Approved for 115.2esr.

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/55707ed5c948
https://hg.mozilla.org/releases/mozilla-esr115/rev/76d511fd1fc0