Closed Bug 1841232 Opened 2 years ago Closed 2 years ago

Only pass frame object to frame scopes selectors

Categories

(DevTools :: Debugger, task)

Product:
DevTools
Component:
Debugger
Type:
task

Tracking

(firefox117 fixed)

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

Bug 1841232 - [devtools] Only pass the frame object to Frame Scope selector functions.
48 bytes, text/x-phabricator-request
Details | Review

We are currently passing frame id and thread id whereas we have access to the frame object in all callsites and could only pass it.

The frame object already has a reference to the related thread,
and the sourceId can be fetched late instead of being passed in all these functions.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2fe5008962d5 [devtools] Only pass the frame object to Frame Scope selector functions. r=devtools-reviewers,bomsy

https://hg.mozilla.org/mozilla-central/rev/2fe5008962d5

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: