1841410 - Uncaught TypeError: existingElement.details is undefined - unified-toolbar.mjs:393

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[betterbird.project+5]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36 Edg/114.0.1823.67

Steps to reproduce:

Started TB with the icon of the add-on "Signature Switch" in the unified toolbar.

Uncaught TypeError: existingElement.details is undefined
    wantedElements chrome://messenger/content/unifiedtoolbar/unified-toolbar.mjs:393
    #showToolbarForSpace chrome://messenger/content/unifiedtoolbar/unified-toolbar.mjs:381
    #handleSpaceChange chrome://messenger/content/unifiedtoolbar/unified-toolbar.mjs:237
    onTabSwitched chrome://messenger/content/spacesToolbar.js:163
    registerTabMonitor chrome://messenger/content/tabmail.js:694
    onLoad chrome://messenger/content/spacesToolbar.js:314
    loadPostAccountWizard chrome://messenger/content/messenger.js:614
    loadStylesheets jar:file:///D:/MAIL-THUNDERBIRD/jorgk.default/extensions/[e-mail]!/experiments.js:18
    addWindowListener jar:file:///D:/MAIL-THUNDERBIRD/jorgk.default/extensions/[e-mail]!/experiments.js:51
    result resource://gre/modules/ExtensionParent.sys.mjs:1144
    withCallContextData resource://gre/modules/ExtensionParent.sys.mjs:627
    result resource://gre/modules/ExtensionParent.sys.mjs:1143
    withPendingBrowser resource://gre/modules/ExtensionParent.sys.mjs:637
    result resource://gre/modules/ExtensionParent.sys.mjs:1142
    callAndLog resource://gre/modules/ExtensionParent.sys.mjs:1095
    recvAPICall resource://gre/modules/ExtensionParent.sys.mjs:1141
unified-toolbar.mjs:393:11

It appears that for toolbar entries which come from add-ons, existingElement.details isn't set:
https://searchfox.org/comm-central/rev/78245f927ad4c32e6896f5ceee7483083f90bf59/mail/components/unifiedtoolbar/content/unified-toolbar.mjs#393

The issue was observed on a large profile. It happens at random, seems like a timing issue.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1841410 - Don't expect details to be set on customizable-element. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/51129f50e3e2
Don't expect details to be set on customizable-element. r=kaie

Comment 3

[Martin Giger [:freaktechnik]]

Comment on attachment 9342072 [details]
Bug 1841410 - Don't expect details to be set on customizable-element. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1817911
User impact if declined: Unified toolbar keyboard navigation might misbehave with extensions.
Testing completed (on c-c, etc.): Manual testing only.
Risk to taking this patch (and alternatives if risky): Low risk, increases resilience and very little changes.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9342072 [details]
Bug 1841410 - Don't expect details to be set on customizable-element. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr115

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 115.0:
https://hg.mozilla.org/releases/comm-esr115/rev/73998d98c0fb