1841480 - Cannot customize unified toolbar with tab for PDF viewer

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect, P3)

Description

[Alistair Cunningham]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/114.0

Steps to reproduce:

If you right click on the toolbar that shows a search box in a tab for viewing a PDF file, there's a "Customise..." option. However, this doesn't seem to work. There's no way to remove the search box or add new buttons.

Comment 1

[Wayne Mery (:wsmwk)]

Attachment: Screenshot 2023-07-04 at 2.46.20 AM.png

1. open pdf
2. click customize

Comment 2

[Wayne Mery (:wsmwk)]

Nothing in error console.
I don't think this is urgent for 115, so P3

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: Bug 1841480 - Properly handle initialization of unified toolbar outside a space. r=#thunderbird-front-end-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8d5b5cf81c03
Properly handle initialization of unified toolbar outside a space. r=aleca

Comment 5

[Martin Giger [:freaktechnik]]

Comment on attachment 9342197 [details]
Bug 1841480 - Properly handle initialization of unified toolbar outside a space. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Unified toolbar customization (and unified toolbar itself) doesn't initialize properly when first shown in a tab without space.
Testing completed (on c-c, etc.): Manual testing
Risk to taking this patch (and alternatives if risky): Low risk

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9342197 [details]
Bug 1841480 - Properly handle initialization of unified toolbar outside a space. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 116.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/321a77683695

Comment 8

[Martin Giger [:freaktechnik]]

Comment on attachment 9342197 [details]
Bug 1841480 - Properly handle initialization of unified toolbar outside a space. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Opening ut customization sometimes inexplicably fails, as well as unified toolbar initializing wrong
Testing completed (on c-c, etc.): Tested on beta
Risk to taking this patch (and alternatives if risky): Low risk

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9342197 [details]
Bug 1841480 - Properly handle initialization of unified toolbar outside a space. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr115

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 115.0.1:
https://hg.mozilla.org/releases/comm-esr115/rev/b1ab5034a374