1841498 - Convert GV's BrowserUsageTelemetry.jsm to ESM

Status: RESOLVED FIXED

(GeckoView :: General, task)

Description

[Makoto Kato [:m_kato]]

We need to convert mobile version too. (dom references this module. https://searchfox.org/mozilla-central/rev/7069822ab03c425676187eadca1d8e0d84ff3b5b/dom/base/Document.cpp#18037, so bug 1834831 causes a regression.)

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1841498 - Convert BrowserUsageTelemetry.jsm to ESM. r=#geckoview-reviewers!

Bug 1834831 forgot converting mobile version since
Document::AutomaticStorageAccessPermissionCanBeGranted uses this module.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0647e42fb1f
Convert BrowserUsageTelemetry.jsm to ESM. r=geckoview-reviewers,calu

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a0647e42fb1f

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 9342087 [details]
Bug 1841498 - Convert BrowserUsageTelemetry.jsm to ESM. r=#geckoview-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: Bug 1573236 / Bug 1573238's feature becomes broken after landing bug 1834831
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Bug 1834831 converts Desktop's JSM to ESM, but it forget converting GeckoView module
• String changes made/needed:
• Is Android affected?: Yes

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9342087 [details]
Bug 1841498 - Convert BrowserUsageTelemetry.jsm to ESM. r=#geckoview-reviewers!

Approved for 116.0b2

Comment 6

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0ad6b9042321