1841572 - add/edit button doesn't take all the available space

Status: VERIFIED FIXED

(Fenix :: Bookmarks, enhancement, P3)

Description

[Mike a [:mavduevskiy]]

Attachment: IMAGE 2023-07-04 11:20:08.jpg

Add/Edit Bookmark checkbox button in three dot menu in some locales ellipsizes words more, than it should. Checkbox has its own spacing, as does the container. It doubles the 16dp padding we were aiming for.

Even regular menu items, with just text and icon, would get ellipsized, but the checkbox button has two texts and two icons. Common sense is to ellipsize the checkbox button, as the main text introduces some context of what to expect of the additional button, also button is stateful of itself.

Currently the UX team is reworking the menu, so I would not expect a proper solution to this, but it seems we at least could use all the available space for the button.

a follow up to 1823645

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1841572 – removed extra spacing from the bookmark menu item (#2697)

Comment 2

[BMO Github Automation]

Authored by mike a
https://github.com/mozilla-mobile/firefox-android/commit/5137bb15a526f059a0be1c2c67486788d9fbc785
[main] Bug 1841572 – added styles to checkbox menu item views and overrode it on fenix side to give checkbox button more space for text

Comment 3

[Lorand Janos]

Managed to reproduce on the latest RC 117.0.1, latest Beta (118.0b5) and earlier Nightly builds.
Verified as fixed on the latest Nightly build (119.0a1 from 2023-09-08).
Used the German language as an example.
Device used: Google Pixel 7 (Android 14).
Marking the ticket as verified.

Comment 4

[Lorand Janos]

Attachment: Before (3).png

Comment 5

[Lorand Janos]

Attachment: After (3).png