1854645 - 10.55 - 10.34% espn FirstVisualChange / espn fcp (Android) regression on Fri September 8 2023

Status: RESOLVED INVALID

(Firefox for Android :: Bookmarks, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a browsertime performance regression from push 5137bb15a526f059a0be1c2c67486788d9fbc785. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
11%	espn FirstVisualChange	android-hw-a51-11-0-aarch64-shippable-qr	cold webrender	967.43 -> 1,069.48
10%	espn fcp	android-hw-a51-11-0-aarch64-shippable-qr	cold webrender	850.98 -> 939.01

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1841572

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1841572

Comment 3

[Mike a [:mavduevskiy]]

sorry for getting back late.

Where could I read more about the tests? I went through the guide, but still have a very vague idea what the marked tests are doing. The change is pretty minor (affects styling), I am a bit puzzled how it could regress anything. but judging by the last 30days graphs the numbers are pretty much the same as before. Do we still suspect that it might be a regression?

Comment 4

[Donal Meehan [:dmeehan]]

Adding a NI for :alexandrui to take a look at Comment 3.

Comment 5

[Donal Meehan [:dmeehan]]

:vdreghici could this be triaged for severity?
It looks like there isn't much of a change in the graph from before the patch landed

Comment 6

[Vlad Dreghici [:vdreghici]]

Taking a look at the push I don't really understand how that could affect performance. By looking at the graphs I don't notice a significant change either. I have assigned S3 to this until we have more info.

Comment 7

[Alexandru Ionescu (needinfo me) [:alexandrui]]

hi :dmeehan. Sorry for getting back late too. Yes, the performance change might be just graph noise. I just noticed a possible alert before this one and I did some backfills. Will wait for the jobs to finish and keep you updated about the outcome.

Comment 8

[Dianna Smith [:diannaS]]

any update here? marking 120 as fix-optional based on the severity.

Comment 9

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Hello! Thank you for your patience, seems like the 90 days graph reveal that were not much performance chenges, but just a local hiccup and noise.