Closed Bug 1841762 Opened 1 year ago Closed 10 months ago

We should always have a valid queryContext in onEngagement

Categories

(Firefox :: Address Bar, task, P3)

Product:
Firefox
Component:
Address Bar
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
123 Branch
Tracking Flags:
Tracking Status
firefox123 --- fixed

People

(Reporter: mak, Assigned: daleharvey)

References

(Regressed 1 open bug)

Details

(Whiteboard: [sng-scrubbed][search-tech-debt])

Attachments

(1 file, 1 obsolete file)

Bug 1841762 - Ensure onEngagement has queryContext defined. r=mak
48 bytes, text/x-phabricator-request
Details | Review

Sometimes queryContext is undefined, my suspect is that it's for the "start" engagement, but should be verified.

Always having a context has some advantages:

  1. it is less error prone
  2. we can use context.isPrivate in the onEngagement implementations instead of inferring it from controller.input
Severity: N/A → S4
Priority: -- → P3
Whiteboard: [sng-scrubbed][search-tech-debt]
Assignee: nobody → dharvey
Attachment #9370184 - Attachment is obsolete: true
Attachment #9370206 - Attachment description: WIP: Bug 1841762 - Ensure onEngagement has queryContext defined → Bug 1841762 - Ensure onEngagement has queryContext defined. r=adw
Attachment #9370206 - Attachment description: Bug 1841762 - Ensure onEngagement has queryContext defined. r=adw → Bug 1841762 - Ensure onEngagement has queryContext defined. r=mak
Pushed by dharvey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/743bf7dec6d1 Ensure onEngagement has queryContext defined. r=mak

https://hg.mozilla.org/mozilla-central/rev/743bf7dec6d1

Status: NEW → RESOLVED
Closed: 10 months ago
status-firefox123: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: