1886140 - TypeError: can't access property "isPrivate", queryContext is undefined

Status: REOPENED

(Firefox :: Address Bar, defect, P3)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: typeError

Found in

• Fx125.0b1

Affected versions

• Fx 126.0a1
• Fx 125.0b1
• Fx 124.0RC

Affected platforms

• Windows
• Ubuntu
• macOS

Steps to reproduce

1. Launch Firefox and open the browser console.
2. Navigate to any website and copy some text or a link.
3. Open a new tab and right click the address bar.
4. Choose the 'Paste & Go' option.

Expected result

• User is taken to the appropriate page(either SERP or website) without any errors.

Actual result

• The following error is displayed in the console:

TypeError: can't access property "isPrivate", queryContext is undefined
    onEngagement resource:///modules/UrlbarProviderTopSites.sys.mjs:338
    tryMethod resource:///modules/UrlbarUtils.sys.mjs:2367
    notifyEngagementChange resource:///modules/UrlbarProvidersManager.sys.mjs:351
    _internalRecord resource:///modules/UrlbarController.sys.mjs:970
    record resource:///modules/UrlbarController.sys.mjs:827
    handleNavigation resource:///modules/UrlbarInput.sys.mjs:747
    handleCommand resource:///modules/UrlbarInput.sys.mjs:598
    _initPasteAndGo resource:///modules/UrlbarInput.sys.mjs:3158 

Regression range

• First bad: 2024-01-19
• Last good: 2024-01-18
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2b70f662a79773d519e78f0b8b64723a20b1e788&tochange=743bf7dec6d18c0026d8344a68f43f19b2f9308f

Additional notes

• The error received on beta and RC builds has a slightly different name, but the same files seem to be affected:

TypeError: queryContext is undefined
    onEngagement resource:///modules/UrlbarProviderTopSites.sys.mjs:310
    tryMethod resource:///modules/UrlbarUtils.sys.mjs:2365
    notifyEngagementChange resource:///modules/UrlbarProvidersManager.sys.mjs:351
    _internalRecord resource:///modules/UrlbarController.sys.mjs:1026
    record resource:///modules/UrlbarController.sys.mjs:840
    handleNavigation resource:///modules/UrlbarInput.sys.mjs:747
    handleCommand resource:///modules/UrlbarInput.sys.mjs:598
    _initPasteAndGo resource:///modules/UrlbarInput.sys.mjs:3093

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:daleharvey, since you are the author of the regressor, bug 1841762, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1886140 - Fix undefined queryContext in paste-and-go. r=adw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c59be65c8118
Fix undefined queryContext in paste-and-go. r=adw

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c59be65c8118

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and RC is affected.
:daleharvey, is this bug important enough to require an uplift?

• If yes, please nominate the patch for release approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I can still reproduce this issue on Firefox Nighly 126.0a1(latest nightly build), on macOS/Windows 10/Ubuntu 22 using the same steps as in Comment 0.

Comment 7

[Dale Harvey (:daleharvey)]

Yeh the impact is low here, no need to uplift

Comment 8

[Cristian Baica [:cbaica], Release Desktop QA]

Re-opening the issue based on the last comment left from QA.

Comment 9

[Dale Harvey (:daleharvey)]

Attachment: Bug 1886140 - Prevent console errors during 'Paste & Go'. r=adw

Comment 10

[Pier Angelo Vendrame]

I'm still encountering this error, and the patch that hasn't landed seems not to be enough to fix it, from what I can see.
I don't know if it can be helpful, but before finding this bug I investigated a little bit, and I noticed that when opening a new tab, the URL bar is already focused.
Whereas, when re-using the current tab, you will go through this stack trace, which correctly initializes queryContext:

startQuery (moz-src:///browser/components/urlbar/UrlbarController.sys.mjs#125)
startQuery (moz-src:///browser/components/urlbar/UrlbarInput.sys.mjs#1900)
autoOpen (moz-src:///browser/components/urlbar/UrlbarView.sys.mjs#706)
_on_focus (moz-src:///browser/components/urlbar/UrlbarInput.sys.mjs#4538)
handleEvent (moz-src:///browser/components/urlbar/UrlbarInput.sys.mjs#775)

Comment 11

[Dale Harvey (:daleharvey)]

Yeh thats why I hadnt landed it I noticed it was still possible to reproduce, happy for someone to take it over if anyone wants to, thanks for the investigation that could help