1841896 - [meta] Port APZ Fission tests in browser_test_group_fission.js to regular mochitests running in M-fis or M-fis-xorig mode

Status: ASSIGNED

(Core :: Panning and Zooming, task, P3)

Description

[Botond Ballo [:botond]]

APZ has a suite of browser-chrome mochitests for testing issues specific to Fission in browser_test_group_fission.js. There are currently 19 subtests in this suite.

These tests use the FissionTestHelper actor (parent, child), and pre-date the ability of regular mochitests to exercise Fission codepaths.

It should be possible to re-formulate many of these tests as plain mochitests running in M-fis or M-fis-xorig test jobs. This bug tracks this porting work.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking as a potential issue for Android Fission.

Comment 2

[Botond Ballo [:botond]]

(In reply to Chris Peterson [:cpeterson] from comment #1)

Tracking as a potential issue for Android Fission.

Indeed, this is quite relevant to Android Fission. I didn't realize this at the time I filed the bug, but the browser-mochitest suite does not run on Android, while mochitest-plain does.

So, the mentioned porting work will not only simplify APZ's Fission-related tests, it will also bring that test coverage to Android.

Comment 3

[[:owlish] 🦉 PST]

Hi Botond, can this work get prioritized? We are hoping to fix all failing Fission tests this summer, it would be great to improve the test coverage as well. We are hoping to prepare for running experiments in early Q3

Comment 4

[Botond Ballo [:botond]]

(In reply to [:owlish] 🦉 PST from comment #3)

Hi Botond, can this work get prioritized?

Yes, this is on our roadmap. I believe Alex plans to work on this next after bug 1855990, so we should be looking to start this in the Q2 timeframe. Given the number of tests involved, completion of the port will likely be in Q3.

Comment 5

[Alex Jakobi [:ajakobi]]

Currently working on this, so far ported

• helper_fission_basic.html
• helper_fission_transforms.html

Comment 6

[Alex Jakobi [:ajakobi]]

Attachment: Bug 1841896 - Port helper_fission_transforms to regular mochitests r?botond,hiro

Comment 7

[Alex Jakobi [:ajakobi]]

Attachment: Bug 1841896 - Port APZ Fission tests to regular mochitests r?botond,hiro

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb0bfa2e818c
Port helper_fission_transforms to regular mochitests r=hiro

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cb0bfa2e818c

Comment 10

[Alex Jakobi [:ajakobi]]

Attachment: Bug 1841896 - Port helper_fission_tap to regular mochitests r=hiro

Comment 11

[Alex Jakobi [:ajakobi]]

Attachment: Bug 1841896 - Port helper_fission_tap_on_zoomed to regular mochitests r=hiro

Comment 12

[Alex Jakobi [:ajakobi]]

Attachment: Bug 1841896 - Port helper_fission_touch to regular mochitests r=hiro

Comment 13

[Alex Jakobi [:ajakobi]]

Attachment: Bug 1841896 - Port helper_fission_scroll_handoff to regular mochitests r=hiro

Comment 14

[Alex Jakobi [:ajakobi]]

Attachment: Bug 1841896 - Port helper_fission_inactivescroller_under_oopif to regular mochitests r=hiro

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c604c837c187
Port helper_fission_tap to regular mochitests r=hiro
https://hg.mozilla.org/integration/autoland/rev/9817add495d7
Port helper_fission_tap_on_zoomed to regular mochitests r=hiro
https://hg.mozilla.org/integration/autoland/rev/38b3ecfc4223
Port helper_fission_touch to regular mochitests r=hiro
https://hg.mozilla.org/integration/autoland/rev/b049c13d095c
Port helper_fission_scroll_handoff to regular mochitests r=hiro

Comment 16

[Iulian Moraru]

Backed out for causing mochitest-plain failures on test_group_fission.html.

• Push with failures

• Failure log
  Before relanding this, please take a look at this TV failures that were also caused by this:

• example 1

• example 2

• Backout link

[task 2024-08-13T14:23:01.480Z] 14:23:01     INFO -  TEST-START | gfx/layers/apz/test/mochitest/test_group_fission.html
[task 2024-08-13T14:23:01.480Z] 14:23:01     INFO -  Buffered messages logged at 14:22:54
[task 2024-08-13T14:23:01.480Z] 14:23:01     INFO -  TEST-PASS | gfx/layers/apz/test/mochitest/test_group_fission.html | Starting subtest helper_fission_scroll_handoff.html
[task 2024-08-13T14:23:01.480Z] 14:23:01     INFO -  Buffered messages finished
[task 2024-08-13T14:23:01.480Z] 14:23:01  WARNING -  TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/mochitest/test_group_fission.html | Error: Native wheel events not supported on platform android
[task 2024-08-13T14:23:01.480Z] 14:23:01     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:426:16
[task 2024-08-13T14:23:01.481Z] 14:23:01     INFO -      advanceSubtestExecutionWithFailure@gfx/layers/apz/test/mochitest/apz_test_utils.js:400:18
[task 2024-08-13T14:23:01.481Z] 14:23:01     INFO -  must wait for focus
[task 2024-08-13T14:23:01.481Z] 14:23:01     INFO -  TEST-PASS | gfx/layers/apz/test/mochitest/test_group_fission.html | Starting subtest helper_fission_tap.html
[task 2024-08-13T14:23:01.481Z] 14:23:01     INFO -  TEST-PASS | gfx/layers/apz/test/mochitest/test_group_fission.html | Successfully installed event listener in OOP iframe
[task 2024-08-13T14:23:11.542Z] 14:23:11  WARNING -  TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/mochitest/test_group_fission.html | x-coord -43 landed near expected value 141.42135623730948
[task 2024-08-13T14:23:11.542Z] 14:23:11     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:426:16
[task 2024-08-13T14:23:11.542Z] 14:23:11     INFO -      test@gfx/layers/apz/test/mochitest/helper_fission_tap.html:69:9
[task 2024-08-13T14:23:11.542Z] 14:23:11     INFO -      async*@gfx/layers/apz/test/mochitest/helper_fission_tap.html:76:8
[task 2024-08-13T14:23:11.542Z] 14:23:11     INFO -  TEST-PASS | gfx/layers/apz/test/mochitest/test_group_fission.html | y-coord 140 landed near expected value 141.42135623730948
[task 2024-08-13T14:23:11.542Z] 14:23:11     INFO -  must wait for focus
[task 2024-08-13T14:23:11.543Z] 14:23:11     INFO -  TEST-PASS | gfx/layers/apz/test/mochitest/test_group_fission.html | Starting subtest helper_fission_tap_on_zoomed.html
[task 2024-08-13T14:23:11.543Z] 14:23:11     INFO -  TEST-PASS | gfx/layers/apz/test/mochitest/test_group_fission.html | Successfully installed event listener in OOP iframe
[task 2024-08-13T14:23:21.612Z] 14:23:21     INFO -  TEST-PASS | gfx/layers/apz/test/mochitest/test_group_fission.html | x-coord 99 landed near expected value 100
[task 2024-08-13T14:23:21.612Z] 14:23:21     INFO -  TEST-PASS | gfx/layers/apz/test/mochitest/test_group_fission.html | y-coord 99 landed near expected value 100
[task 2024-08-13T14:23:21.612Z] 14:23:21     INFO -  must wait for focus
[task 2024-08-13T14:23:21.612Z] 14:23:21     INFO -  TEST-PASS | gfx/layers/apz/test/mochitest/test_group_fission.html | Starting subtest helper_fission_touch.html
[task 2024-08-13T14:23:21.612Z] 14:23:21     INFO -  TEST-PASS | gfx/layers/apz/test/mochitest/test_group_fission.html | Successfully installed event listeners in OOP iframe
[task 2024-08-13T14:23:21.612Z] 14:23:21     INFO -  must wait for focus
[task 2024-08-13T14:23:21.612Z] 14:23:21     INFO -  TEST-PASS | gfx/layers/apz/test/mochitest/test_group_fission.html | Starting subtest helper_fission_transforms.html
[task 2024-08-13T14:23:21.612Z] 14:23:21     INFO -  TEST-PASS | gfx/layers/apz/test/mochitest/test_group_fission.html | Successfully installed event listener in OOP iframe
[task 2024-08-13T14:23:21.612Z] 14:23:21     INFO -  TEST-PASS | gfx/layers/apz/test/mochitest/test_group_fission.html | x-coord 140 landed near expected value 141.42135623730948
[task 2024-08-13T14:23:21.613Z] 14:23:21     INFO -  TEST-PASS | gfx/layers/apz/test/mochitest/test_group_fission.html | y-coord 140 landed near expected value 141.42135623730948
[task 2024-08-13T14:23:21.613Z] 14:23:21     INFO -  TEST-OK | gfx/layers/apz/test/mochitest/test_group_fission.html | took 25444ms
[task 2024-08-13T14:23:21.613Z] 14:23:21     INFO -  TEST-START | gfx/layers/apz/test/mochitest/test_group_fullscreen.html

Comment 17

[Hiroyuki Ikezoe (:hiro)]

So the failure on helper_fission_tap.html happened only on Android? I guess adding <meta name="viewport" content="width=device-width,initial-scale=1"> solves the failure. (Though I am still wondering why the test fails without the meta tag)

Comment 18

[Alex Jakobi [:ajakobi]]

Working on it, thanks Iulian and Hiro.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7da3ff61f6d
Port helper_fission_tap to regular mochitests r=hiro
https://hg.mozilla.org/integration/autoland/rev/4ac527fb4725
Port helper_fission_tap_on_zoomed to regular mochitests r=hiro
https://hg.mozilla.org/integration/autoland/rev/b87b3d42da4f
Port helper_fission_touch to regular mochitests r=hiro
https://hg.mozilla.org/integration/autoland/rev/70166d915c65
Port helper_fission_scroll_handoff to regular mochitests r=hiro
https://hg.mozilla.org/integration/autoland/rev/2d288f404a50
Port helper_fission_inactivescroller_under_oopif to regular mochitests r=hiro

Comment 20

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f7da3ff61f6d
https://hg.mozilla.org/mozilla-central/rev/4ac527fb4725
https://hg.mozilla.org/mozilla-central/rev/b87b3d42da4f
https://hg.mozilla.org/mozilla-central/rev/70166d915c65
https://hg.mozilla.org/mozilla-central/rev/2d288f404a50

Comment 21

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1841896 - Set zero margin and padding on <html> and <body> in helper_fission_plain.html. r?ajakobi

helper_fission_empty.html does have it [1], it's necessary to make
helper_fission_animation_styling_in_transformed_oopif.html work as a new
mochitest-plain test. (If there was the default 8px margins on <body>, the
animating element in the test is still out of view)

[1] https://searchfox.org/mozilla-central/rev/14a66905574728bc9eb60e927d17d98721167dcf/gfx/layers/apz/test/mochitest/helper_fission_empty.html#5-9
[2] https://searchfox.org/mozilla-central/rev/14a66905574728bc9eb60e927d17d98721167dcf/gfx/layers/apz/test/mochitest/helper_fission_animation_styling_in_transformed_oopif.html

Comment 22

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1841896 - Port helper_fission_animation_styling_in_oopif.htm to a plain mochitest. r?ajakobi

Comment 23

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1841896 - Port helper_fission_animation_styling_in_transformed_oopif.html to a plain mochitest. r?ajakobi

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/843a1a906318
Set zero margin and padding on <html> and <body> in helper_fission_plain.html. r=ajakobi
https://hg.mozilla.org/integration/autoland/rev/13ab55f7bdc6
Port helper_fission_animation_styling_in_oopif.htm to a plain mochitest. r=ajakobi
https://hg.mozilla.org/integration/autoland/rev/1cb4179b4336
Port helper_fission_animation_styling_in_transformed_oopif.html to a plain mochitest. r=ajakobi

Comment 25

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/843a1a906318
https://hg.mozilla.org/mozilla-central/rev/13ab55f7bdc6
https://hg.mozilla.org/mozilla-central/rev/1cb4179b4336

Comment 26

[[:owlish] 🦉 PST]

Hi Alex, is there much work left on this? Thanks!

Comment 27

[Hiroyuki Ikezoe (:hiro)]

Yes. (Alex is on PTO)

Comment 28

[Botond Ballo [:botond]]

To give a bit more detail on the current status:

• There are 18 tests in total
• 6 have been ported and enabled on both desktop and Android
• 2 have been ported but only enabled on desktop so far because they fail on Android (bug 1914368 and bug 1915378 track enabling these on Android)
• 10 tests remain to be ported

Comment 29

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #28)

• 6 have been ported and enabled on both desktop and Android
• 2 have been ported but only enabled on desktop so far because they fail on Android (bug 1914368 and bug 1915378 track enabling these on Android)

(Though I did notice that 2 of the ported tests are not listed in the test group, and therefore not running, at all. I filed bug 1922710 about this.)

Comment 30

[Alex Jakobi [:ajakobi]]

Attachment: Bug 1841896 - Port helper_fission_setResolution to regular mochitests r=hiro

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb67959de9e5
Port helper_fission_setResolution to regular mochitests r=hiro

Comment 32

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/cb67959de9e5

Comment 33

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1841896 - Port helper_fission_irregular_areas.html to a plain mochitest. r?ajakobi

Comment 34

[Hiroyuki Ikezoe (:hiro)]

I originally wrote D227908 as a part of bug 1923513, but after some thoughts, now I think the change should be post here in this bug for being tracked in future.

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/480c30b779ea
Port helper_fission_irregular_areas.html to a plain mochitest. r=ajakobi

Comment 36

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/480c30b779ea

Comment 37

[Alex Jakobi [:ajakobi]]

Attachment: WIP: Bug 1841896 - Port helper_fission_scroll_oopif to regular mochitests r=hiro