1841903 - Reuse Maybe-utils in VideoDecoder for VideoFrame and EncodedVideoChunk

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, task, P1)

Description

[C.M.Chang[:chunmin]]

The utils converting types among Maybe, Nullable, and Optional added in VideoDecoder should be reused in VideoFrame (e.g., VideoFrame::GetDuration()) and EncodedVideoChunk (e.g., EncodedVideoChunk::GetDuration()).

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1841903 - Move Maybe-utils to WebCodecUtils

The utils for conversion among Maybe, Nullable, and Optional added in
VideoDecoder should be moved to WebCodecsUtils so other files like
VideoFrame and EncodedVideoChunk can reuse those functions

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1841903 - Reuse utils in VideoFrame and EncodedVideoChunk

Depends on D182834

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1841903 - Use utils in ChunkData ctor

Depends on D182835

Comment 4

[C.M.Chang[:chunmin]]

Attachment: Bug 1841903 - Apply const to ChunkData members if possible

Depends on D182837

Comment 5

[C.M.Chang[:chunmin]]

Attachment: Bug 1841903 - Add lines to align style

This patch add some empty lines right after some utils implementation
sections so now all the utils implementations start from one empty line
after their section descriptions

Depends on D182834

Comment 6

[C.M.Chang[:chunmin]]

Attachment: Bug 1841903 - Store EncodedVideoChunk data in MediaByteBuffer

EncodedVideoChunk serialization will take a reference to the data
stored in the chunk. Using MediaByteBuffer is a better choice for data
storage since it implies it can be shared.

Depends on D182838

Comment 7

[Phabricator Automation]

Comment on attachment 9342479 [details]
Bug 1841903 - Store EncodedVideoChunk data in MediaByteBuffer

Revision D182843 was moved to bug 1838984. Setting attachment 9342479 [details] to obsolete.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33021233c2e9
Move Maybe-utils to WebCodecUtils r=padenot
https://hg.mozilla.org/integration/autoland/rev/1ce06e14e96b
Add lines to align style r=padenot
https://hg.mozilla.org/integration/autoland/rev/0027a9fd3c45
Reuse utils in VideoFrame and EncodedVideoChunk r=padenot
https://hg.mozilla.org/integration/autoland/rev/61f6eaaa51d6
Use utils in ChunkData ctor r=padenot
https://hg.mozilla.org/integration/autoland/rev/5cea29422288
Apply const to ChunkData members if possible r=padenot

Comment 9

[Norisz Fay [:noriszfay]]

Backed out for causing Video related build bustages

Backout link

Push with failures

Failure log

Comment 10

[C.M.Chang[:chunmin]]

Attachment: Bug 1841903 - Fix define guard style

Per https://google.github.io/styleguide/cppguide.html#The__define_Guard,
the define guard should be formed by the path

Depends on D182838

Comment 11

[C.M.Chang[:chunmin]]

I've updated D182834 and now it should work: https://treeherder.mozilla.org/jobs?repo=try&revision=df661d3c95da2b05b45bed0cce217548b4e0394f&selectedTaskRun=IWQxqm4mRqqUrGxdTB9o9w.0

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/065ed7d4aa36
Move Maybe-utils to WebCodecUtils r=padenot
https://hg.mozilla.org/integration/autoland/rev/85ed2643fa93
Add lines to align style r=padenot
https://hg.mozilla.org/integration/autoland/rev/f46d9f80e879
Reuse utils in VideoFrame and EncodedVideoChunk r=padenot
https://hg.mozilla.org/integration/autoland/rev/25df3d359143
Use utils in ChunkData ctor r=padenot
https://hg.mozilla.org/integration/autoland/rev/472a16c1f7dd
Apply const to ChunkData members if possible r=padenot
https://hg.mozilla.org/integration/autoland/rev/b336a3ad3e0e
Fix define guard style r=media-playback-reviewers,alwu

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/065ed7d4aa36
https://hg.mozilla.org/mozilla-central/rev/85ed2643fa93
https://hg.mozilla.org/mozilla-central/rev/f46d9f80e879
https://hg.mozilla.org/mozilla-central/rev/25df3d359143
https://hg.mozilla.org/mozilla-central/rev/472a16c1f7dd
https://hg.mozilla.org/mozilla-central/rev/b336a3ad3e0e