Closed
Bug 1841967
Opened 2 years ago
Closed 2 years ago
Stop using context in React components where it isn't relevant
Categories
(DevTools :: Debugger, task)
DevTools
Debugger
Tracking
(firefox117 fixed)
RESOLVED
FIXED
117 Branch
| Tracking | Status | |
|---|---|---|
| firefox117 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(3 files)
Yet another clone of bug 1841041 to continue this work while helping keep track of patches landed in which version.
| Assignee | ||
Comment 1•2 years ago
|
||
These actions take a source as input, but at the end we end up setting overrides
against URLs which aren't specific to any particular page/pause location.
Updated•2 years ago
|
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
| Assignee | ||
Comment 2•2 years ago
|
||
| Assignee | ||
Comment 3•2 years ago
|
||
Step and resume actions (command action) are acting on the currently selected thread,
so that there is no need to pass a context. This action could also query the selectors
to guess what is the currently selected thread.
Updated•2 years ago
|
Attachment #9342562 -
Attachment description: Bug 1841967 - [devtools] Remove leftover "cx" variable from preview actions. → Bug 1841967 - [devtools] Remove leftover "cx" variable from preview and command actions.
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0490f94b41d9
[devtools] Remove context from override source actions. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/05db01d0d1b9
[devtools] Remove leftover "cx" variable from preview and command actions. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/c5910091179c
[devtools] Align breakOnNext with step and resume actions. r=devtools-reviewers,bomsy
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0490f94b41d9
https://hg.mozilla.org/mozilla-central/rev/05db01d0d1b9
https://hg.mozilla.org/mozilla-central/rev/c5910091179c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox117:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•