1842478 - Remove layout.css.individual-transform.enabled pref

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Gregory Pappas [:gregp]]

Individual transform properties have been enabled for about 4 years now (bug 1424900). Let's remove this feature rollout pref

Comment 1

[Gregory Pappas [:gregp]]

Attachment: Bug 1842478 - Remove layout.css.individual-transform.enabled pref r?boris!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da009889019a
Remove layout.css.individual-transform.enabled pref r=boris,devtools-reviewers

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing build bustage in gfx/layers/AnimationInfo.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/94f83ed2c1c988bad1ce6f634c8e1c543b0f7fbb

Push with failures

Failure log -> ERROR - /builds/worker/checkouts/gecko/gfx/layers/AnimationInfo.cpp(958,21): error: no member named 'layout_css_individual_transform_enabled'

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1b105230b62
Remove layout.css.individual-transform.enabled pref r=boris,devtools-reviewers

Comment 5

[Cristian Tuns]

Backed out for causing mochitest failures in test_transitions_and_zoom.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_and_zoom.html | Test timed out. -

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:gregp, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 7

[Boris Chiou [:boris]]

Hi Gregory,
Please let me know if there are any issues to land this.

Comment 8

[Gregory Pappas [:gregp]]

Sorry, I've been busy recently.

I was able to reproduce the failure locally, I think i know what the issue is and will try landing this later today.

Comment 9

[Boris Chiou [:boris]]

No hurry for this. This is probably just an auto ni from the system. :)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6cdd02295e2d
Remove layout.css.individual-transform.enabled pref r=boris,devtools-reviewers

Comment 11

[Sandor Molnar[:smolnar]]

Backed out for causing for causing mochitest failures on layout/style/test/test_transitions_and_zoom.html CLOSED TREE

Backout link: https://hg.mozilla.org/integration/autoland/rev/10a16ed7ab96f82333671271e198f19ce031f38a

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_and_zoom.html | Test timed out

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afa417babef9
Remove layout.css.individual-transform.enabled pref r=boris,devtools-reviewers

Comment 13

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in test_transitions_per_property.html.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-TIMEOUT | layout/style/test/test_transitions_per_property.html | application timed out after 370 seconds with no output

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/492682d091f1
Remove layout.css.individual-transform.enabled pref r=boris,devtools-reviewers

Comment 15

[Gregory Pappas [:gregp]]

If anyone's curious why this kept getting backed out:

It turns out layout/style/test/test_shared_sheet_caching.html opens a new tab. This unfocuses the mochitest harness which caused test_transitions_per_property.html to stall. What I still don't understand is why my changes exposed this. It seems like something that would have always been an issue. All I did was remove a pref read... either way, the solution was childWin.close(), this seemed to fix everything.

cc emilio who added test_shared_sheet_caching.html

Comment 16

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/492682d091f1