1842482 - Reimplement middle click "open message in a tab" action

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P3)

Description

[dreadnaut]

Steps to reproduce:

In Thunderbird 102.x and earlier, clicking with the middle button on a folder or message selects the folder/message, and opens it in a background new tab.

Actual results:

In Thunderbird 116.0b1, clicking with the middle button has no effect: no selection, no new tab.

Expected results:

I would expect Supernova to implement the existing middle-click behaviour: select the folder/message, and open it in a new background tab.

The feature is particularly useful when the "Open messages in:" option is set to "A new message window": double-click will open in a new window, and middle-click in a new tab.

Comment 1

[Wayne Mery (:wsmwk)]

I can confirm this.

Comment 2

[dreadnaut]

Just realised this is an almost-duplicate of bug 1836853, which mentions folders, but not messages.

Comment 3

[solange]

Attachment: Bug 1842482 - Reimplement middle click on message list to open tabs in background. r=aleca,elizabeth

Comment 4

[Anje]

Windows 10
Confirmed issue in 116.0b3

Comment 6

[dreadnaut]

With the title change from "Middle click on folder or message should open a tab" to "Reimplement middle click on message list to open tabs in background", we have lost the "on folder" part of the issue.

It probably make sense to keep the two separate. Should I open a new bug for the "Reimplement middle click on folder to open tabs in background" ?

Comment 7

[solange]

(In reply to dreadnaut from comment #6)

With the title change from "Middle click on folder or message should open a tab" to "Reimplement middle click on message list to open tabs in background", we have lost the "on folder" part of the issue.

It probably make sense to keep the two separate. Should I open a new bug for the "Reimplement middle click on folder to open tabs in background" ?

Thanks for the offer! There is already a bug tracking that issue so it shouldn't be needed.

Comment 8

[dreadnaut]

Ah, search failed me — or I need to learn how to use it 😅

Thank you!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e263d251112e
Reimplement middle click on message list to open tabs in background. r=aleca,elizabeth

Comment 10

[solange]

Comment on attachment 9343198 [details]
Bug 1842482 - Reimplement middle click on message list to open tabs in background. r=aleca,elizabeth

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: User would not be able to open messages on new tab using the middle click
Testing completed (on c-c, etc.): extensive manual and automated testing
Risk to taking this patch (and alternatives if risky): low

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: User would not be able to open messages on new tab using the middle click
Testing completed (on c-c, etc.): extensive manual and automated testing
Risk to taking this patch (and alternatives if risky): low

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9343198 [details]
Bug 1842482 - Reimplement middle click on message list to open tabs in background. r=aleca,elizabeth

[Triage Comment]
This will appear in 118 beta, and then uplifted to a point release after 115.2.0

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9343198 [details]
Bug 1842482 - Reimplement middle click on message list to open tabs in background. r=aleca,elizabeth

[Triage Comment]
Approved for esr115

Comment 15

[Daniel Darnell [:dandarnell]]

Thunderbird 115.2.1:
https://hg.mozilla.org/releases/comm-esr115/rev/d430fb5d04c7

Comment 16

[dreadnaut]

I recently updated Thunderbird to 115.2.2, and noticed that middle-click on a message now has an effect. However, it does not open a message in a new tab, but it follows the "Open messages in" option, under "Settings" -> "Reading & Display".

If the options is set to "A new tab", middle-clicking on a message will open it in a new tab, if it's set to "A new message window", a new window will pop up. This makes it no different than double clicking or hitting Enter.

I would expect middle-click to always open a message in a new tab, unaffected by the "Open messages in" setting. From this point of view, the issue is not fixed unfortunately.

Something else I noticed (if this is not expected behaviour, I can open a separate issue)

• middle-click on a column header or on empty space opens the currently selected message
• double-click on empty space opens the currently selected message

Comment 17

[Anje]

Using 118.0b4
Requirements:

• Single left click on selected message to open in 'Message Pane' and have focus
• Double click on selected message to open in A new message Window and have focus
• Single middle click on selected email to open message in a new tab in background.

Settings

• Enable 'Message Pane'
• Set : 'Settings' > 'General' > 'Reading & Display' - select open messages in 'A new message window'

Actual:

• Single click opens message in Message Pane and has focus
• Double click opens message in a new Window with focus
• Middle click opens message in a new Window with focus

Expected:

• Single click opens message in Message Pane and has focus
• Double click opens message in a new Window with focus
• Middle click open selected email in a new tab in the background.

Confirm single middle-click will open in the area designated in 'Settings' > 'General' > 'Reading & Display'.
Single middle click should open in tab in background regardless of what is set up in the 'Reading & Display' settings.

This bug has not been fixed although it has made middle click operational, just not performing the expected result.

Comment 18

[Alessandro Castellani [:aleca]]

Please don't reopen bugs, and don't change the title of closed bugs, especially since patches have been already uplifted.
Report the wrong behaviour in a follow up bug blocked or regressed by the original bug.

Comment 19

[Anje]

(In reply to Alessandro Castellani [:aleca] from comment #18)

Please don't reopen bugs, and don't change the title of closed bugs, especially since patches have been already uplifted.
Report the wrong behaviour in a follow up bug blocked or regressed by the original bug.

Just to make sure I understand the process used on this forum:
If a bug is set as 'Resolved' but a bad patch was uplifted which did not fix bug then a new bug must be opened purely on the basis that a patch was uplifted on this bug.
You never reopen incorrectly marked as resolved bugs if any patch whether it fixed the bug or as in this case did not fix this bug.

Comment 20

[Anje]

As requested, I have opened a new bug 1853923

Comment 21

[Alessandro Castellani [:aleca]]

(In reply to Anje from comment #19)

If a bug is set as 'Resolved' but a bad patch was uplifted which did not fix bug then a new bug must be opened purely on the basis that a patch was uplifted on this bug.
You never reopen incorrectly marked as resolved bugs if any patch whether it fixed the bug or as in this case did not fix this bug.

We only reopen bugs if the patch gets backout, since the golden rule is to keep 1 patch per bug and if the patch lands the bug should reflect the correct state of the patch.
For all other cases, opening a follow up or regression is the recommended flow.

Comment 22

[Anje]

(In reply to Alessandro Castellani [:aleca] from comment #21)

(In reply to Anje from comment #19)

If a bug is set as 'Resolved' but a bad patch was uplifted which did not fix bug then a new bug must be opened purely on the basis that a patch was uplifted on this bug.
You never reopen incorrectly marked as resolved bugs if any patch whether it fixed the bug or as in this case did not fix this bug.

We only reopen bugs if the patch gets backout, since the golden rule is to keep 1 patch per bug and if the patch lands the bug should reflect the correct state of the patch.
For all other cases, opening a follow up or regression is the recommended flow.

Many thanks Alessandro. I understand.