1842948 - Application menu item reads "Name=Open the Address Book" for flatpak

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Sean Burke [:leftmostcat]]

Attachment: menu-screenshot.png

When opening the application menu in GNOME while using the 115 flatpak, the "Open the Address Book" menu item is incorrectly prefixed with "Name=".

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1842948 - Fix incorrect application menu item for Flatpak. r=#thunderbird-build-system-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ef91de83b706
Fix incorrect application menu item for Flatpak. r=dandarnell

Comment 3

[Rob Lemley [:rjl]]

Comment on attachment 9343506 [details]
Bug 1842948 - Fix incorrect application menu item for Flatpak. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
Regression caused by (bug #): N/A new feature
User impact if declined: The desktop menu entry to open the address book reads "Name=Open Address Book"
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): Low, just fixes the template used to build the .desktop file

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9343506 [details]
Bug 1842948 - Fix incorrect application menu item for Flatpak. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 116.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/299455db0209

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9343506 [details]
Bug 1842948 - Fix incorrect application menu item for Flatpak. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for esr115

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 115.1.0:
https://hg.mozilla.org/releases/comm-esr115/rev/3dd9f710eeb1