1843045 - Set WMClass in Flatpak .desktop file

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Rob Lemley [:rjl]]

Firefox sets StartupWMClass in their Flatpak .desktop file, and it's pretty much necessary to get taskbar icons to show up right on Wayland.

Firefox always sets StartupWMClass=firefox though, which is incorrect for beta versions. It should be "firefox-beta". (Bug 1826330?)

Since Thunderbird's .desktop file is already generated via Jinja2 template to get translated strings, StartupWMClass can easily be set appropriately for beta builds.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1843045 - Set StartupWMClass in Thunderbird Flatpak .desktop file. r=#thunderbird-build-system-reviewers

Depends on D183386

Comment 2

[Rob Lemley [:rjl]]

Comment on attachment 9343507 [details]
Bug 1843045 - Set StartupWMClass in Thunderbird Flatpak .desktop file. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: Taskbar icon may be a generic application icon for Flatpak users running on Wayland
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): Low risk. Adds a line to the .desktop file that's needed for Wayland users.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ce1f17a138e6
Set StartupWMClass in Thunderbird Flatpak .desktop file. r=dandarnell

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9343507 [details]
Bug 1843045 - Set StartupWMClass in Thunderbird Flatpak .desktop file. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 116.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/9d2b7651a95b

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9343507 [details]
Bug 1843045 - Set StartupWMClass in Thunderbird Flatpak .desktop file. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for esr115

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 115.1.0:
https://hg.mozilla.org/releases/comm-esr115/rev/9390ce7d833b