1843102 - Fix crash reporter in flatpak

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Emerson Bernier]

In order to make crash reported work in Thunderbird Flatpak:

1. Enable flatpak debug symbols processing:

https://hg.mozilla.org/mozilla-central/rev/c1d723b1a88ffc044bb38659f7b841b33255e783

2. Add flatpak --allow=devel permission in runme.sh

https://hg.mozilla.org/mozilla-central/rev/f8cb988231f6f9544c41735cd9b8c776d2bf0556

Comment 1

[:gerard-majax]

(In reply to Emerson Bernier from comment #0)

https://hg.mozilla.org/mozilla-central/rev/c1d723b1a88ffc044bb38659f7b841b33255e783

Be aware all of this code is only tested for running against firefox targets, you might hit some breakage, and adding thunderbird support will require a bit of work on taskcluster side as well

Comment 2

[Emerson Bernier]

(In reply to :gerard-majax [PTO 01/08/2023-10/09/2023] from comment #1)

(In reply to Emerson Bernier from comment #0)

https://hg.mozilla.org/mozilla-central/rev/c1d723b1a88ffc044bb38659f7b841b33255e783

Be aware all of this code is only tested for running against firefox targets, you might hit some breakage, and adding thunderbird support will require a bit of work on taskcluster side as well

The first part of firefox fix can be treated as food for thought. The second part (--allow=devel option in flatpak manifest) is simple fix that allows to create a crashdump. I think it can be added right away - without it flatpak users are left just with "unable to create crashdump" dialog when TB crashes.

Comment 3

[Rob Lemley [:rjl]]

I might be missing something, but I don't think part 1 is necessary for Thunderbird.

Those are the "system symbols" in the Flatpak, so we're talking about things like libgtk, libcups, etc that are included via the org.mozilla.firefox.BaseApp and freedesktop-sdk, correct?

That being the case, IIUC Thunderbird benefits from the scraping and uploads done for Firefox so there's no reason to duplicate efforts there. I can look in crash-stats and see that "gtk_printer_get_name" from "libgtk-3.so.0" is at "gtk/gtkprinter.c:436" in a Thunderbird crash for example.

Adding --allow=devel is easy enough.

Comment 4

[Rob Lemley [:rjl]]

Attachment: Bug 1843102 - Port bug 1653852: Add features=devel to flatpak packages for crash reporter to work. r=#thunderbird-build-system-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/379aacb426a3
Port bug 1653852: Add features=devel to flatpak packages for crash reporter to work. r=dandarnell

Comment 6

[Rob Lemley [:rjl]]

Comment on attachment 9349904 [details]
Bug 1843102 - Port bug 1653852: Add features=devel to flatpak packages for crash reporter to work. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: Crash reporter fails on Flatpak builds due to sandboxing
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Low risk, Firefox does the same.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9349904 [details]
Bug 1843102 - Port bug 1653852: Add features=devel to flatpak packages for crash reporter to work. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for esr115

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 115.2.1:
https://hg.mozilla.org/releases/comm-esr115/rev/a94397be3ec2