Hover box remains if firefox is minimized
Categories
(Core :: Widget: Win32, defect)
Tracking
()
People
(Reporter: marcausl, Assigned: emilio)
References
(Regression)
Details
(Keywords: nightly-community, regression)
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr115+
|
Details | Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0
Steps to reproduce:
Hover anyplace that opens and information box. The bookmark icon for example. Minimize firefox using window-down.
Actual results:
The info box remains on the desktop and will remain on top of any other window opened under its position.
Expected results:
Info box should close.
(Sorry - I don't know the correct terminology. When you place the mouse cursor over many places, a box appears showing additional information.)
Reporter | ||
Comment 1•10 months ago
|
||
It appears this is a firefox bug. I've opened Bug 1843205 - Hover box remains if firefox is minimized.
Comment 2•10 months ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
Reporter | ||
Comment 3•10 months ago
|
||
Not about bookmarks and history - just used that as an example. Any hover fails this way.
Comment 4•10 months ago
|
||
I can reproduce the issue on Nightly117.0a1 Windows10.
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e26e137b43919fa0b07e0667cc597a290c22f175&tochange=6f2d406b412b3969220dc3eb84653882784ab1bb
Updated•10 months ago
|
Comment 5•10 months ago
|
||
:emilio, since you are the author of the regressor, bug 1828587, could you take a look? Also, could you set the severity field?
For more information, please visit BugBot documentation.
Comment 6•10 months ago
|
||
Hmm, is it the hunk that changes
mViewManagerFlushIsPending
to
(mViewManagerFlushIsPending && !mThrottled)
in nsRefreshDriver::HasObservers?
Comment 7•10 months ago
|
||
See screencast: https://youtu.be/1ssq4GMsKlQ
Assignee | ||
Updated•10 months ago
|
Assignee | ||
Updated•10 months ago
|
Assignee | ||
Comment 8•10 months ago
|
||
Just like we rollup menus.
This is needed because tooltips otherwise get hidden on mousedown and
don't flush the view manager.
This matches the similar hunk for GTK in bug 1569439.
Comment 9•10 months ago
|
||
[Tracking Requested - why for this release]: Thunderbird115 is also affected (see Bug 1843269). So, It would be worth fixing with Firefox 115esr.
Reporter | ||
Comment 10•10 months ago
|
||
Note that this bug also affects Thunderbird whose new major release is based on
Comment 11•10 months ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f31967cea44 Rollup tooltips on WM_KILLFOCUS. r=handyman
Updated•10 months ago
|
Comment 12•10 months ago
|
||
bugherder |
Comment 13•10 months ago
|
||
The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox116
towontfix
.
For more information, please visit BugBot documentation.
Reporter | ||
Comment 14•10 months ago
|
||
Reminder that this also affects thunderbird 115.
Assignee | ||
Comment 15•10 months ago
|
||
I'm not sure it's worth uplifting to 116 given it's a regression in 114 and I think the case should be rather rare (minimizing the window with keyboard while having a mouse tooltip open). But let me know if I'm missing something and this shows up more commonly?
Updated•10 months ago
|
Assignee | ||
Comment 17•10 months ago
|
||
Comment on attachment 9343686 [details]
Bug 1843205 - Rollup tooltips on WM_KILLFOCUS. r=tnikkel,cmartin,handyman
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Affects TB 115 and firefox, can be annoying for users.
- User impact if declined: tooltips remain on screen.
- Fix Landed on Version: 117
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Pretty scoped change.
Reporter | ||
Comment 19•10 months ago
|
||
An easy workaround is setting browser.chrome.toolbar_tips.hide_on_keydown to 1.
Updated•10 months ago
|
Updated•10 months ago
|
Comment 20•10 months ago
|
||
Reproducible on a 2023-07-12 Nightly build on Windows 10.
Verified as fixed on Firefox 117.0b2(build ID: 20230801180159) and Nightly 118.0a1(build ID: 20230801034557) on Windows 10 and Windows 11.
Comment 21•10 months ago
|
||
Comment on attachment 9343686 [details]
Bug 1843205 - Rollup tooltips on WM_KILLFOCUS. r=tnikkel,cmartin,handyman
Approved for 115.2esr.
Comment 22•10 months ago
|
||
uplift |
https://hg.mozilla.org/releases/mozilla-esr115/rev/6626c95c5d1d
Updated•10 months ago
|
Comment 24•9 months ago
|
||
Reproducible on a 2023-07-12 Nightly build on Windows 10.
Verified as fixed on ESR 115.2(treeherder build) on Windows 10 and Windows 11.
Description
•