1843205 - Hover box remains if firefox is minimized

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Marc Auslander]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

Hover anyplace that opens and information box. The bookmark icon for example. Minimize firefox using window-down.

Actual results:

The info box remains on the desktop and will remain on top of any other window opened under its position.

Expected results:

Info box should close.
(Sorry - I don't know the correct terminology. When you place the mouse cursor over many places, a box appears showing additional information.)

Comment 1

[Marc Auslander]

It appears this is a firefox bug. I've opened Bug 1843205 - Hover box remains if firefox is minimized.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Marc Auslander]

Not about bookmarks and history - just used that as an example. Any hover fails this way.

Comment 4

[Alice0775 White]

I can reproduce the issue on Nightly117.0a1 Windows10.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e26e137b43919fa0b07e0667cc597a290c22f175&tochange=6f2d406b412b3969220dc3eb84653882784ab1bb

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1828587, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 6

[Timothy Nikkel (:tnikkel)]

Hmm, is it the hunk that changes

mViewManagerFlushIsPending
to
(mViewManagerFlushIsPending && !mThrottled)

in nsRefreshDriver::HasObservers?

Comment 7

[Alice0775 White]

See screencast: https://youtu.be/1ssq4GMsKlQ

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1843205 - Rollup tooltips on WM_KILLFOCUS. r=tnikkel,cmartin,handyman

Just like we rollup menus.

This is needed because tooltips otherwise get hidden on mousedown and
don't flush the view manager.

This matches the similar hunk for GTK in bug 1569439.

Comment 9

[Alice0775 White]

[Tracking Requested - why for this release]: Thunderbird115 is also affected (see Bug 1843269). So, It would be worth fixing with Firefox 115esr.

Comment 10

[Marc Auslander]

Note that this bug also affects Thunderbird whose new major release is based on

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f31967cea44
Rollup tooltips on WM_KILLFOCUS. r=handyman

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0f31967cea44

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox116 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[Marc Auslander]

Reminder that this also affects thunderbird 115.

Comment 15

[Emilio Cobos Álvarez [:emilio]]

I'm not sure it's worth uplifting to 116 given it's a regression in 114 and I think the case should be rather rare (minimizing the window with keyboard while having a mouse tooltip open). But let me know if I'm missing something and this shows up more commonly?

Comment 17

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9343686 [details]
Bug 1843205 - Rollup tooltips on WM_KILLFOCUS. r=tnikkel,cmartin,handyman

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Affects TB 115 and firefox, can be annoying for users.
• User impact if declined: tooltips remain on screen.
• Fix Landed on Version: 117
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Pretty scoped change.

Comment 19

[Marc Auslander]

An easy workaround is setting browser.chrome.toolbar_tips.hide_on_keydown to 1.

Comment 20

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-07-12 Nightly build on Windows 10.
Verified as fixed on Firefox 117.0b2(build ID: 20230801180159) and Nightly 118.0a1(build ID: 20230801034557) on Windows 10 and Windows 11.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9343686 [details]
Bug 1843205 - Rollup tooltips on WM_KILLFOCUS. r=tnikkel,cmartin,handyman

Approved for 115.2esr.

Comment 22

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/6626c95c5d1d

Comment 24

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-07-12 Nightly build on Windows 10.
Verified as fixed on ESR 115.2(treeherder build) on Windows 10 and Windows 11.