1843221 - TB 115 - no indicator on ignored threads in thread pane for unthreaded view

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[wrhenshaw99]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36

Steps to reproduce:

I selected View > Threads > Ignored Threads.

Actual results:

The ignored threads were shown but no icon (the circle with a line through it) was on the messages so it was almost impossible to figure out which ones they were.

Expected results:

In TB 102 and prior versions the icon was visible on messages in ignored threads. This should be the case in TB 115 as well.

Comment 1

[Wayne Mery (:wsmwk)]

Thanks for the bug report.

Confirmed with 115.0. Also fails with recent daily.
Note, also needs to work for ignore subthread, which I think is a different icon.

Comment 2

[Alessandro Castellani [:aleca]]

Uh oh, something must have broken this since I remember Geoff worked on it and I reviewed the patches, and it was working

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: image.png

Works for me. Are you seeing the thread icon instead of the ignored icon, or no icon at all? If you're not seeing any icon, check that the Thread column is visible.

Comment 4

[Alessandro Castellani [:aleca]]

If you used the context menu, that works.
It doesn't if you go through the View > Threads menu.

Comment 5

[wrhenshaw99]

I have the thread pane, but no icon.

https://i.imgur.com/M6kWsGq.jpg

Bill

Comment 6

[wrhenshaw99]

I meant I have the thread column, but no icon.

Bill

Comment 7

[wrhenshaw99]

Sorry, I should have added that I don't use thread view. I use unthreaded. In TB 102 if I said to view ignored threads, the icon would show in the thread column.

Bill

Comment 8

[wrhenshaw99]

To see if I would see the thread icon, I tried to switch to threaded view. If I select View > Sort by > Threaded, nothing happens. The setting does not get changed at View > Sort by and the messages do not get displayed in threaded view.

Bill

Comment 9

[Geoff Lankow (:darktrojan)]

(In reply to wrhenshaw99 from comment #7)

Sorry, I should have added that I don't use thread view. I use unthreaded. In TB 102 if I said to view ignored threads, the icon would show in the thread column.

Ah, okay. That makes a difference. We'll have a look into that.

Comment 10

[Alessandro Castellani [:aleca]]

This issue also happens for me in Threaded view, but only if I use the Menubar View > Threads submenu.
The context menu of the message works.

Comment 11

[wrhenshaw99]

Some additional information...

If I go into troubleshoot mode, I am able to switch from unthreaded to threaded mode. In threaded mode the ignored thread icon does show.

This is another situation (see above) where manually disabling the extensions doesn't help, but using troubleshoot mode does.

If I manually disable all my extensions, why wouldn't that do the same thing as troubleshoot mode?

Somehow the update from TB 102 to TB 115 doesn't seem to have gone smoothly.

Bill

Comment 12

[wrhenshaw99]

Allesandro said "This issue also happens for me in Threaded view, but only if I use the Menubar View > Threads submenu.
The context menu of the message works."

I don't know how to quote in Bugzilla.

Allesandro, I don't understand what you mean. I have no View > Threads > Ignored threads option in the context menu.

Bill

Comment 13

[Alessandro Castellani [:aleca]]

(In reply to wrhenshaw99 from comment #12)

Allesandro, I don't understand what you mean. I have no View > Threads > Ignored threads option in the context menu.

Right click > Ignore Threads, is there at the bottom.

Comment 14

[wrhenshaw99]

Allesandro, I am still confused. It seems like you are mixing and matching the setting of ignored threads and the viewing of ignored threads.

Oh well... I'm not sure comment #4 was direct at me anyway. I was just trying to understand what you were saying.

I do use Right click > Ignore Thread, to ignore the thread. I use View > Threads > Ignored Threads to view them (which is what isn't working for me).

Thanks,
Bill

Comment 15

[wrhenshaw99]

(In reply to wrhenshaw99 from comment #8)

To see if I would see the thread icon, I tried to switch to threaded view. If I select View > Sort by > Threaded, nothing happens. The setting does not get changed at View > Sort by and the messages do not get displayed in threaded view.

Bill

I just wanted to clarify this comment I made in comment #8. The problem I describe ended up not being a problem in Thunderbird. It was caused by the extension Cardbook. If I disable Cardbook it works fine. However, I still don't get any icon in the thread column when in View unthreaded mode which I did get with TB 102.

Bill

Comment 16

[wrhenshaw99]

I've discovered that the problem goes deeper than described. Un unthreaded mode, if I ignore a thread it doesn't disappear immediately from the message list as it did in prior versions. The only way I can make them disappear is to click on View > Threads > Ignored threads and then click on View > Threads > Ignored threads again order to de-deselect it.

Bill

Comment 17

[wrhenshaw99]

(In reply to wrhenshaw99 from comment #16)

I've discovered that the problem goes deeper than described. Un unthreaded mode, if I ignore a thread it doesn't disappear immediately from the message list as it did in prior versions. The only way I can make them disappear is to click on View > Threads > Ignored threads and then click on View > Threads > Ignored threads again order to de-deselect it.

Bill

Or maybe I'm just confused. In earlier versions they may have not gone away, but at least had the icon next to them showing they were ignored.

Bill

Comment 18

[Wayne Mery (:wsmwk)]

correcting bugzilla mistake

Comment 19

[Alfred Peters [:infofrommozilla]]

Attachment: Restore icons for watched and ignored threads in unthreaded view

The two cases were forgotten in Bug 1823389.

The code line is a bit long. Can it stay like this?
Or can it possibly be merged?

Comment 20

[Alessandro Castellani [:aleca]]

So...question.
Why is it necessary to show the "ignore thread" state if the view is "unthreaded"?

Comment 21

[wrhenshaw99]

Just because I view messages in unthreaded mode doesn't mean I don't want to be able to identify the messages that are part of an ignored thread. when I select View > Ignored Threads. Sometimes I do this to look at a message that is part of an ignored thread.

I guess my question is, why it is necessary to remove this icon from unthreaded mode when it has been there in all previous versions of Thunderbird that I have used in the last 10 years or more?

Bill

Comment 22

[Alessandro Castellani [:aleca]]

(In reply to wrhenshaw99 from comment #21)

I guess my question is, why it is necessary to remove this icon from unthreaded mode when it has been there in all previous versions of Thunderbird that I have used in the last 10 years or more?

That's a good question, but the answer is not a simple "we removed it on purpose" as you might have figured from the thread in this bug in whcih we didn't even know it behaved that way.

The larger question is "does X make sense when in Y?"
With the rebuild of our architecture to get rid of crusty old code, we stumbled upon many of these situations, in which some features and behaviours have been implemented decades ago but not documented nor tested, so being aware of those and the reasons why they were added it's very tricky and not intuitive.

Supporting a feature means adding documentation, adding a test, and making sure that that feature is not broken accidentally, consequentially avoiding what we're experiencing right now, which is a bug report in which our initial response is "wait, what? I can't reproduce this", because we weren't even aware that the thread indicator was supposed to be in the un-threaded view.

I hope you can understand how internally it makes sense for us reaching the conclusion "un-threaded view === no need for threads related indicators".

Even tho the fix seems straightforward with a single CSS change, that's only the beginning as we need to ensure this expected feature is documented and covered by tests, so development and maintenance burden.

Comment 23

[Alessandro Castellani [:aleca]]

Comment on attachment 9350338 [details] [diff] [review]
Restore icons for watched and ignored threads in unthreaded view

Review of attachment 9350338 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for tackling this.
Would you be able to submit this patch to Phabricator? We don't accept patches in bugzilla anymore because it breaks our automated landing process.
Also, would you be able to update the test to cover this scenario? https://searchfox.org/comm-central/rev/2fe8694a034fc959c6fd761b5b8f22f368d5463f/mail/base/test/browser/browser_threads.js#99

Comment 24

[wrhenshaw99]

Does this mean that the icon will return to unthreaded view? I wasn't sure after reading your last two comments.

Bill

Comment 25

[Alfred Peters [:infofrommozilla]]

Attachment: Bug 1843221 - Restore icons for watched and ignored threads in unthreaded view. r=aleca

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6f62b9cc3c3f
Restore icons for watched and ignored threads in unthreaded view. r=aleca