1843244 - Full Screen Video on Firefox Nightly displays the Android notification area in grey.

Status: VERIFIED FIXED

(Firefox for Android :: Onboarding, defect)

Description

[Woolio]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0
Firefox for Android

Steps to reproduce:

I am using Firefox Nightly on Android.
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

This is rather simple. I was watching a video full screen on Nightly and the far left of the screen, the area which corresponds to the notification area in vertical mode, is grey. Not the expected black. It makes the front facing camera stand out and also gives me burn in concerns.

Installing the stable Firefox version this works as intended.

Actual results:

Area is grey.

Expected results:

Area should be black.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::WebRTC: Audio/Video' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Dan Baker[:dbaker]]

Thank you for reporting this issue. I am able to reproduce what you are seeing and my initial investigation points to it being introduced by bug 1839522.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:mavduevskiy, since you are the author of the regressor, bug 1839522, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Alastor Wu [:alwu]]

Per comment2, move this bug to another component.

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1843244 – fixed notch background color (#2888)

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1839522

Comment 7

[BMO Github Automation]

Authored by mike a
https://github.com/mozilla-mobile/firefox-android/commit/7c523f85e33674b5c3de6aedf53cc9d05d6b4178
[main] Bug 1843244 – fixed notch background color

Comment 8

[Lorand Janos]

Managed to reproduce this issue on an earlier Nightly 117.0a1 build.

Verified as fixed on the latest Nightly 117.0a1 build from 2023-07-26.

The previously grey area is now black.

Device used: Oppo Find X5 (Android 13).

Marking the ticket as verified for 117.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mavduevskiy, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox116 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Chris Peterson [:cpeterson]]

Mike, should we consider uplifting this fix to a 116 dot release? We tentatively have a 116.1 scheduled for August 7 and a 116.2 scheduled for August 14.

Comment 11

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1843244 – fixed notch background color (backport #2888) (#3077)

Comment 12

[Mike a [:mavduevskiy]]

Comment on attachment 9346772 [details] [review]
[mozilla-mobile/firefox-android] Bug 1843244 – fixed notch background color (backport #2888) (#3077)

Beta/Release Uplift Approval Request

• User impact if declined: The devices with a notch in horizontal area won't have the notch area blacked out, like it normally is. instead, it will have the same background as the screen background. screenshots in PR show it nicely: link
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): There is no "code", just manipulating styling parameters through xml
• String changes made/needed: no
• Is Android affected?: Yes

Comment 13

[Mike a [:mavduevskiy]]

:cpeterson nice catch, thank you!

Comment 14

[Dianna Smith [:diannaS]]

Comment on attachment 9346772 [details] [review]
[mozilla-mobile/firefox-android] Bug 1843244 – fixed notch background color (backport #2888) (#3077)

Approved for Mobile dot release 116.2.0

Comment 15

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/1631c1a4ea867df594799e5fdf23cf9862433e31
[releases_v116] Bug 1843244 – fixed notch background color (#3077)

Comment 17

[Delia Pop (Android QA)]

Marking the version 116 verified fixed as well. The issue is fixed in latest RC 116.2.0 with the following devices:

• Google Pixel 7 Pro (Android 14)
• Lenovo tab M10 (Android 10)
• OnePlus 6T (Android 9)
• Huawei MediaPad M2 (Android 5.1.1)