1843293 - Clicking the Add image button from the PDF toolbar should open the Upload dialog directly

Status: RESOLVED DUPLICATE of bug 1848108

(Firefox :: PDF Viewer, enhancement)

Description

[Rares Doghi, Desktop QA]

Found in

• Nightly 117.0a1 (2023-07-12)

Affected versions

• Nightly 117.0a1 (2023-07-12)

Tested platforms

• Affected platforms: ALL

Steps to reproduce

1. Open a PDF file in Firefox.
2. Click the "Add an image" button from the PDF toolbar.

Expected result

• The Upload modal should open directly and allow the user to select an image.
• After the file is selected it should be opened and displayed in the middle of the PDF page or in the Top Left corner of the page where the user could move and resize it.

Actual result

• Clicking the Add an image button from the PDF toolbar does not do anything until the user clicks inside the pdf file. (This could also be great if there was an indication that we also have to click somewhere inside the page, Maybe the mouse cursor could change its state into something else similar to DRAW or maybe we can show the image preview or maybe the frame could be visible around the mouse cursor just to let people know they have to place it somewhere.)

Regression range

• N/A

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:rdoghi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Marco Castelluccio [:marco]]

I agree we should do this, it seems more natural. Usama, any thoughts?

Comment 3

[Calixte Denizet (:calixte)]

My rational for doing that was just to have consistent tools:

• click on a tool icon
• click somewhere on the page to add an editor.

Comment 4

[Jonas Jenwald [:Snuffleupagus]]

Couldn't there be one potential annoyance if we automatically open the file-picker whenever the Stamp-editor is enabled?
More specifically, consider the following steps:

1. Enable the Stamp-editor.
2. Click somewhere on a page to add an image.
3. Disable the Stamp-editor.
4. Decide that you want to move and/or resize the image.
5. Enable the Stamp-editor again, to allow manipulating the previously inserted image.

It seems to me that if we implement what this bug suggests the file-picker would be automatically opened in step 5, which seems quite annoying when all you wanted to do was move/resize an existing image.

Comment 5

[Marco Castelluccio [:marco]]

(In reply to Jonas Jenwald [:Snuffleupagus] from comment #4)

Couldn't there be one potential annoyance if we automatically open the file-picker whenever the Stamp-editor is enabled?
More specifically, consider the following steps:

1. Enable the Stamp-editor.
2. Click somewhere on a page to add an image.
3. Disable the Stamp-editor.
4. Decide that you want to move and/or resize the image.
5. Enable the Stamp-editor again, to allow manipulating the previously inserted image.

It seems to me that if we implement what this bug suggests the file-picker would be automatically opened in step 5, which seems quite annoying when all you wanted to do was move/resize an existing image.

Fixing bug 1787298 and bug 1843525 would alleviate these concerns as the user could just move and/or resize by selecting the image, they wouldn't have to enable the Stamp-editor again.

Comment 6

[Marco Castelluccio [:marco]]

Dasha is going to help with this. Given how many users were confused, I'm pretty sure we'll have to change this.