Closed Bug 1844624 Opened 2 years ago Closed 2 years ago

Tooltip of PDF Image button "Add an image" is inconsistent and potentially confusing

Categories

(Firefox :: PDF Viewer, defect, P3)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1848108

People

(Reporter: glob, Unassigned)

References

Details

The tooltip of the Image toolbar icon is "Add an image". I was expecting that clicking on this button would open a standard file dialog so I can select an image to add. Instead all it does is make the button active.

For a while I thought it was just broken, until I accidentally clicked on the canvas and then presented with a standard file dialog.

Then I was confused that the button stayed depressed. After playing with other PDF editing features (which I was unfamiliar with before today) I realised that portion of the toolbar was a mode select, allowing me to switch between placing images, text, or drawing lines.

If the image button wasn't the first one that I'd ever used, it would have been clearer how it worked. However, this was not the case, probably because it's the leftmost icon (but also because I wanted to play with the image placement feature).

Suggestions:

  • Make it clear that the three buttons (image, text, draw) are for editing the PDF and are modal (somehow!)
  • Use consistent language in the tooltips - either "Add an image", "Add text", and "Add drawing"; or "Image", "Text", and "Draw"
  • Open the standard file dialog immediately upon clicking on the toolbar icon; or provide some other UI hint that a placement on the PDF is required before selecting a file, not after (like most other document editors)
See Also: → 1843293
Blocks: 1846099
No longer blocks: pdf-js-edit

The severity field is not set for this bug.
:calixte, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(cdenizet)
Severity: -- → S3
Flags: needinfo?(cdenizet)
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 2 years ago
Duplicate of bug: 1848108
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.